[Bug 18915] New: Creating a checkout note (patron note) sends an incomplete email message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Bug ID: 18915 Summary: Creating a checkout note (patron note) sends an incomplete email message Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Taken from bug 14224: (Marcel de Rooy from comment #122 )
<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.item>> - <<biblio.author>> (<<biblio.biblionumber>>).
What is biblio.item supposed to print here? I got this mail: M De Rooy has added a note to the item - Schwartz, Randal L (23).
And must say that it might not be that clear.. Do we need biblio.title and an item number ?
Have tested and can confirm that this bug exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64937&action=edit Bug 18915: Fix checkout note email message This patch changes patron_note to checkout_note in the appropriate places, and ensures the email gets the title of the item. To test: 1) Apply patch and update database 2) View the message_queue table in mysql 3) Check out an item if haven't already 4) Go to OPAC and set a checkout note for an item 5) View message_queue table and confirm it the title is included in the email and all instances of 'patron note' have been replaced with 'checkout note' 6) Disable javascript in browser 7) repeat steps 4 and 5 and confirm all works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14224 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 [Bug 14224] patron notes about item shown at check in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Failed QA --- Comment #2 from Marc Véron <veron@veron.ch> --- What happens if a library has modified the note? - Modifications for title and content would get lost with the following statement in bug_18915_-_modifying_patron_note_notice.sql UPDATE letter SET code = 'CHECKOUT_NOTE', name = 'Checkout note on item set by patron', title = 'Checkout note', content = '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).' WHERE code = 'PATRON_NOTE'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Marc Véron from comment #2)
What happens if a library has modified the note? - Modifications for title and content would get lost with the following statement in bug_18915_-_modifying_patron_note_notice.sql
UPDATE letter SET code = 'CHECKOUT_NOTE', name = 'Checkout note on item set by patron', title = 'Checkout note', content = '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).' WHERE code = 'PATRON_NOTE';
I see what you mean, but this patch is fixing the content of the note, so it does need to be changed. Unless you can think of another way to fix the note? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marc Véron <veron@veron.ch> --- cc Marcel because of the initial comment Maybe a warning in update notes that contents of note have been reset? However, IMO librarians would not be happy about. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think in another case, when <<items.fine>> was introduced, Dobrica managed to just replace the broken bit. Could this be an option here? Just replacing biblio.item with biblio.title? The old database update could give an example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Aleisha Amohia from comment #3)
(In reply to Marc Véron from comment #2)
What happens if a library has modified the note? - Modifications for title and content would get lost with the following statement in bug_18915_-_modifying_patron_note_notice.sql
UPDATE letter SET code = 'CHECKOUT_NOTE', name = 'Checkout note on item set by patron', title = 'Checkout note', content = '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).' WHERE code = 'PATRON_NOTE';
I see what you mean, but this patch is fixing the content of the note, so it does need to be changed. Unless you can think of another way to fix the note?
Aleisha, Could you fix the note by just a SQL replace for the wrong field? UPDATE table SET field = REPLACE(field ,from_str, to_str) etc etc So look for biblio.item only and replace that by biblio.title. If the library changed the note and fixed it already, there will be no problem. Please adjust this entry too: installer/data/mysql/updatedatabase.pl: VALUES ('circulation', 'PATRON_NOTE', '', 'Patron note on item', '0', 'Patron issue note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.item>> - <<biblio.author>> (<<biblio.biblionumber>>).','email'); And do not forget to add PATRON_NOTE (or CHECKOUT_NOTE) to installer/data/mysql/en/mandatory/sample_notices.sql It does not occur yet.. Thanks ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64937|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518&action=edit Bug 18915: Fix checkout note email message This patch replaces the <<biblio.item>> in the email with <<biblio.title>> and uses CHECKOUT_NOTE instead of PATRON_NOTE. This patch also adds the notice to installer/data/mysql/en/mandatory/sample_notices.sql, and updates the PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl To test: 1) Apply patch and update database 2) View the message_queue table in mysql 3) Check out an item if haven't already 4) Go to OPAC and set a checkout note for an item 5) View message_queue table and confirm it the title is included in the email and all instances of 'patron note' have been replaced with 'checkout note' 6) Disable javascript in browser 7) repeat steps 4 and 5 and confirm all works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 66518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518 Bug 18915: Fix checkout note email message Review of attachment 66518: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18915&attachment=66518) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +14308,4 @@
$dbh->do(q| INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`) + VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item set by patron', '0', 'Checkout note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');
I don't think updatedatabase should be modified like this. This is already done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE, if this is correct logic. ::: opac/svc/patron_notes @@ +82,4 @@
my $biblionumber = $issue->item->biblionumber; my $letter = C4::Letters::GetPreparedLetter ( module => 'circulation', + letter_code => 'CHECKOUT_NOTE',
Why even change the letter code, given that you aren't changing the svc name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The test plan works. However, is it normal that if I add <<issues.note>> in the notice it comes back as blank in the message_queue table? I checked and my notes are in the issues table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_17_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- *** Bug 19772 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69839&action=edit Bug 18915: Giving CHECKOUT_NOTE access to issues table This patch allows the notice to reference the issues table so that the checkout note itself can be added to the note if wanted, such as in Comment 9. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to M. Tompsett from comment #8)
::: installer/data/mysql/updatedatabase.pl @@ +14308,4 @@
$dbh->do(q| INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`) + VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item set by patron', '0', 'Checkout note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');
I don't think updatedatabase should be modified like this. This is already done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE, if this is correct logic.
I thought this change was necessary for fresh installs. If the atomic update is enough then I'm happy to take this out.
::: opac/svc/patron_notes @@ +82,4 @@
my $biblionumber = $issue->item->biblionumber; my $letter = C4::Letters::GetPreparedLetter ( module => 'circulation', + letter_code => 'CHECKOUT_NOTE',
Why even change the letter code, given that you aren't changing the svc name?
Mostly so that the name of the note is consistent with the name of the syspref (AllowCheckoutNotes), therefore, the name of the feature. The filename should also be changed as checkout note is more appropriate than patron note anyway - I think this was just a missed case from the original bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69840&action=edit Bug 18915: Renaming svc/patron_notes to svc/checkout_notes For consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA: Please make sure bug 19772 is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #14)
QA: Please make sure bug 19772 is fixed.
Yes this has been fixed. The problem was I'd missed a case when changing PATRON_NOTE to CHECKOUT_NOTE in svc/checkout_notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #16 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Marjorie Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #17 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70376&action=edit Bug 18915: Fix checkout note email message This patch replaces the <<biblio.item>> in the email with <<biblio.title>> and uses CHECKOUT_NOTE instead of PATRON_NOTE. This patch also adds the notice to installer/data/mysql/en/mandatory/sample_notices.sql, and updates the PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl To test: 1) Apply patch and update database 2) View the message_queue table in mysql 3) Check out an item if haven't already 4) Go to OPAC and set a checkout note for an item 5) View message_queue table and confirm it the title is included in the email and all instances of 'patron note' have been replaced with 'checkout note' 6) Disable javascript in browser 7) repeat steps 4 and 5 and confirm all works as expected Sponsored-by: Catalyst IT Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #18 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70377&action=edit Bug 18915: Giving CHECKOUT_NOTE access to issues table This patch allows the notice to reference the issues table so that the checkout note itself can be added to the note if wanted, such as in Comment 9. Sponsored-by: Catalyst IT Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> https://bugs.koha-community.org/show_bug.cgi?id=19801 Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #19 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70378&action=edit Bug 18915: Renaming svc/patron_notes to svc/checkout_notes For consistency. Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> https://bugs.koha-community.org/show_bug.cgi?id=19801 Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70376|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70460&action=edit Bug 18915: Fix checkout note email message This patch replaces the <<biblio.item>> in the email with <<biblio.title>> and uses CHECKOUT_NOTE instead of PATRON_NOTE. This patch also adds the notice to installer/data/mysql/en/mandatory/sample_notices.sql, and updates the PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl To test: 1) Apply patch and update database 2) View the message_queue table in mysql 3) Check out an item if haven't already 4) Go to OPAC and set a checkout note for an item 5) View message_queue table and confirm it the title is included in the email and all instances of 'patron note' have been replaced with 'checkout note' 6) Disable javascript in browser 7) repeat steps 4 and 5 and confirm all works as expected Sponsored-by: Catalyst IT Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70377|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70461&action=edit Bug 18915: Giving CHECKOUT_NOTE access to issues table This patch allows the notice to reference the issues table so that the checkout note itself can be added to the note if wanted, such as in Comment 9. Sponsored-by: Catalyst IT Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> https://bugs.koha-community.org/show_bug.cgi?id=19801 Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70378|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70462&action=edit Bug 18915: Renaming svc/patron_notes to svc/checkout_notes For consistency. Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> https://bugs.koha-community.org/show_bug.cgi?id=19801 Signed-off-by: Marjorie Vila <marjorie.barry-vila@collecto.ca> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70463&action=edit Bug 18915: (QA follow-up) Add note for installs after 17.05 Since the 17.05 upgrade adds the note and the sql file did not yet include the note, we should add it when it is not there (for example new 17.11s). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested by running the dbrev while there is a letter and while not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #15)
(In reply to Jonathan Druart from comment #14)
QA: Please make sure bug 19772 is fixed.
Yes this has been fixed. The problem was I'd missed a case when changing PATRON_NOTE to CHECKOUT_NOTE in svc/checkout_notes.
No it is not fixed, if the notice template does not exist I do receive a success message "Your note about ITEM_TITLE has been saved and sent to the library." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70492&action=edit Bug 18915: Add CHECKOUT_NOTE notice template for other languages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #28 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org