[Bug 31330] New: Branchcode used for routing preview can be wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Bug ID: 31330 Summary: Branchcode used for routing preview can be wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Noticed when working on bug 31318, and discussed on IRC http://irc.koha-community.org/koha/2022-08-09#i_2443598 It seems that we adding/modifying the hold using the holdingbranch of the serial item published first. If no item is created (or no holdingbranch), we are using the subscription.branchcode Shouldn't we use the branchcode of the issue we previously created (if an item exist) instead of the first published one? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The fallback to subscription.branchcode makes sense. But as you wrote, I think using the first item makes no sense - what if you moved part of the holdings into a "closed stacks" library location or just to another branch. This could easily happen in academic libraries where the newest issues might be kept somewhere else than the older less requested items. If an item is linked to the serial via serialitems, we should use the info of this specific item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138912&action=edit Bug 31330: Routing preview - Use the library from the selected issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The code looked so wrong. I have the feeling that this patch is correcting a problem, and clean the code a bit, but I need someone familiar with this page to know if it's correct. The change is about the library used to generate the hold, should it be the one from the holding library (if an item has been created with the serial item)? The one from the first published serial item? If no items have been created then the library from the subscription is used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- code wise more fixes are needed here, especially the creation of methods for Koha::Serial::Item, but that's not in the scope. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
The change is about the library used to generate the hold, should it be the one from the holding library (if an item has been created with the serial item)? The one from the first published serial item? If no items have been created then the library from the subscription is used.
Hm, the hold feature has been broken for so long, that I have never seen it working :( Bug 2894 - Routing list holds are broken So you are probably right about the code not being correct. I think it if there is no item, you can't place a hold and the hold should be an item level hold (it needs to be as serial items represent a specific issue and are not identical). If you have created multiple items on receiving the issue (a recent feature given the age of this code) we might need to pick one, which makes it more complicate than it was in the past maybe. I thought this was a display question for the routing slip until now... should we move the hold stuff elsewhere or does it need to be solved? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31335 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31335 [Bug 31335] unnecessary holds fetch in serials/routing-preview.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31318 [Bug 31318] Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31335 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31335 [Bug 31335] Unnecessary holds fetch in serials/routing-preview.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 [Bug 2894] Routing list holds are broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138912|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166955&action=edit Bug 31330: Routing preview - Use the library from the selected issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166956&action=edit Bug 31330: Don't pass serial_escaped What's the point of this? Am I missing something here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Rebased and adjust. Can we get this moving again? I am a bit lost to be honest. What's needed? Happy to work on it if I get some guidance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hi Any news ? Is this enhancement or bug ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Fridolin Somers from comment #9)
Hi
Any news ? Is this enhancement or bug ?
Why are you asking? We need more eyes on this, so if someone at BibLibre could help it would be great. Look at this and bug 2894. What's the expected behaviour? Are the patches fixing the problem correctly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- A librarian asked about this saying it is a bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31330 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Can they test the patch and confirm it fixes the issue as they would expect? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org