[Bug 28373] New: Items fields not used in default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Bug ID: 28373 Summary: Items fields not used in default XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- searchResults passes the item/952 fields to XSLT for parsing, and we spend time in transformMARC4XSLT translating authorised values in these fields, but our default XSLT never uses them We should make passing them optional to support anyone who has added 952 to their XSLT, but saving time for anyone who has not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121115&action=edit Bug 28373: Add PassItemMarcToXSLT system preference Default stylesheets do not reference item fields for XSLT display, however, we spend time translating the values in the item fields. This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we remove item fields before processing To test: 1 - Perform some search on the staff client and opac 2 - Use the console (F12) to view the time spent on the network tab 3 - Note performance 4 - Apply patch, updatedatabase, restart_all 5 - Repeat searches 6 - Note that display has not changed 7 - Note performance, results should display slightly faster -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28371 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Note: I say "slightly", however, that is a function of how many items are on your records. The perf increase is small on the sample database, but very large on a consortium site with many items per record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But aren't we using the information in the results? Not on the detail page, I agree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
But aren't we using the information in the results? Not on the detail page, I agree.
Not in the XSLT - we are either using the items array we build in searchResults or the items info we build in BuildKohaItemsNameSpace - the item fields in the record are not used in the XSLT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #5)
(In reply to Katrin Fischer from comment #4)
But aren't we using the information in the results? Not on the detail page, I agree.
Not in the XSLT - we are either using the items array we build in searchResults or the items info we build in BuildKohaItemsNameSpace - the item fields in the record are not used in the XSLT
Ah ok, I just remembered hat there was some complicated XSLT there that I never wanted to touch: https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tm... :) That's using output of BuildKohaItemsNameSpace then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
(In reply to Nick Clemens from comment #5)
(In reply to Katrin Fischer from comment #4)
But aren't we using the information in the results? Not on the detail page, I agree.
Not in the XSLT - we are either using the items array we build in searchResults or the items info we build in BuildKohaItemsNameSpace - the item fields in the record are not used in the XSLT
Ah ok, I just remembered hat there was some complicated XSLT there that I never wanted to touch:
https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha- tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl#L1250
:) That's using output of BuildKohaItemsNameSpace then?
Correct, you can verify too that none of that disappears with this patch :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #7)
(In reply to Katrin Fischer from comment #6)
(In reply to Nick Clemens from comment #5)
(In reply to Katrin Fischer from comment #4)
But aren't we using the information in the results? Not on the detail page, I agree.
Not in the XSLT - we are either using the items array we build in searchResults or the items info we build in BuildKohaItemsNameSpace - the item fields in the record are not used in the XSLT
Ah ok, I just remembered hat there was some complicated XSLT there that I never wanted to touch:
https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha- tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl#L1250
:) That's using output of BuildKohaItemsNameSpace then?
Correct, you can verify too that none of that disappears with this patch :-)
All good - just trying to get the picture. Wonder why this patch was chosen? But that question is clearly out of scope here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- patch = path -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121115|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121610&action=edit Bug 28373: Add PassItemMarcToXSLT system preference Default stylesheets do not reference item fields for XSLT display, however, we spend time translating the values in the item fields. This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we remove item fields before processing To test: 1 - Perform some search on the staff client and opac 2 - Use the console (F12) to view the time spent on the network tab 3 - Note performance 4 - Apply patch, updatedatabase, restart_all 5 - Repeat searches 6 - Note that display has not changed 7 - Note performance, results should display slightly faster -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121611&action=edit Bug 28373: (QA follow-up) Fix typo in system preference description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested OPAC, intranet and list result lists. You might want to add a unit test for QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still waiting for the unit test! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121610|0 |1 is obsolete| | Attachment #121611|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122614&action=edit Bug 28373: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122615&action=edit Bug 28373: Add PassItemMarcToXSLT system preference Default stylesheets do not reference item fields for XSLT display, however, we spend time translating the values in the item fields. This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we remove item fields before processing To test: 1 - Perform some search on the staff client and opac 2 - Use the console (F12) to view the time spent on the network tab 3 - Note performance 4 - Apply patch, updatedatabase, restart_all 5 - Repeat searches 6 - Note that display has not changed 7 - Note performance, results should display slightly faster -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122616&action=edit Bug 28373: (QA follow-up) Fix typo in system preference description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, if it's only the unit tests I am happy to leave my sign-off - but I can also come back for QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122614|0 |1 is obsolete| | --- Comment #18 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 122628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122628&action=edit Bug 28373: Unit test Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122615|0 |1 is obsolete| | --- Comment #19 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 122629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122629&action=edit Bug 28373: Add PassItemMarcToXSLT system preference Default stylesheets do not reference item fields for XSLT display, however, we spend time translating the values in the item fields. This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we remove item fields before processing To test: 1 - Perform some search on the staff client and opac 2 - Use the console (F12) to view the time spent on the network tab 3 - Note performance 4 - Apply patch, updatedatabase, restart_all 5 - Repeat searches 6 - Note that display has not changed 7 - Note performance, results should display slightly faster Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122616|0 |1 is obsolete| | --- Comment #20 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 122630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122630&action=edit Bug 28373: (QA follow-up) Fix typo in system preference description Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please check the QA tools? I am having this failure: FAIL t/Search.t FAIL critic # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). OK forbidden patterns OK git manipulation OK pod OK spelling OK valid Also the tests are failing: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/Search.t t/Search.t .. 1/4 # No tests run! # Failed test 'No tests run for subtest "searchResults PassItemMarcToXSLT test"' # at t/Search.t line 207. Undefined subroutine &main::searchResults called at t/Search.t line 197. # Looks like your test exited with 255 just after 4. t/Search.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/4 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124019&action=edit Bug 28373: (follow-up) QA fixes Use fully qualified subroutine name Don't return explicit undef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122628|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124222&action=edit Bug 28373: Unit test Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122629|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124223&action=edit Bug 28373: Add PassItemMarcToXSLT system preference Default stylesheets do not reference item fields for XSLT display, however, we spend time translating the values in the item fields. This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we remove item fields before processing To test: 1 - Perform some search on the staff client and opac 2 - Use the console (F12) to view the time spent on the network tab 3 - Note performance 4 - Apply patch, updatedatabase, restart_all 5 - Repeat searches 6 - Note that display has not changed 7 - Note performance, results should display slightly faster Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122630|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124224&action=edit Bug 28373: (QA follow-up) Fix typo in system preference description Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124019|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124225&action=edit Bug 28373: (follow-up) QA fixes Use fully qualified subroutine name Don't return explicit undef Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124226&action=edit Bug 28373: (QA follow-up) Add . to end of system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When processing records for release notes| |display we loop through | |each field in the record | |and translate authorized | |values into descriptions. | |Item fields in the record | |contain many authorised | |values, and the lookups can | |cause a delay in displaying | |the record. If using the | |default XSLT these fields | |are not displayed as they | |exist in the record, so | |parsing them is not | |necessary and can save | |time. This bug adds a | |system preference that | |disables sending these | |fields for processing and | |thus saving time. Enabling | |the system preference will | |allow users to pass the | |items to custom style | |sheets if needed. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- So people using this processing will have their displays broken. What do we do? Cannot we do this replacement in the xslt itself? (In reply to Nick Clemens from comment #3)
Note: I say "slightly", however, that is a function of how many items are on your records.
The perf increase is small on the sample database, but very large on a consortium site with many items per record
Did you benchmark it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What's actually bad here is that we call GetAuthorisedValueDesc for every subfield that needs to be replaced (and it's not cached). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Shouldn't we also add a note on the xslt syspref's descriptions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124254&action=edit Bug 28373: Add note to XSLT prefs about the new pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124255&action=edit Bug 28373: Add warning if custom stylesheets are defined This patch adds a check of the current XSLT prefs and warns to check the new pref if any are not set to default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #29)
What's actually bad here is that we call GetAuthorisedValueDesc for every subfield that needs to be replaced (and it's not cached).
See bug 28371 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #30)
Shouldn't we also add a note on the xslt syspref's descriptions?
Added, as well as a warning for users with custom sheets. If preferred the update can be made to default to ON -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #32)
Created attachment 124255 [details] [review] Bug 28373: Add warning if custom stylesheets are defined
This patch adds a check of the current XSLT prefs and warns to check the new pref if any are not set to default
I've removed the 'last' and display the syspref's name to provide more information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124495&action=edit Bug 28373: [21.05.x] Add PassItemMarcToXSLT system preference Default stylesheets do not reference item fields for XSLT display, however, we spend time translating the values in the item fields. This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we remove item fields before processing To test: 1 - Perform some search on the staff client and opac 2 - Use the console (F12) to view the time spent on the network tab 3 - Note performance 4 - Apply patch, updatedatabase, restart_all 5 - Repeat searches 6 - Note that display has not changed 7 - Note performance, results should display slightly faster Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 28373: Unit test Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 28373: (QA follow-up) Fix typo in system preference description Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 28373: (follow-up) QA fixes Use fully qualified subroutine name Don't return explicit undef Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 28373: (QA follow-up) Add . to end of system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 28373: Add note to XSLT prefs about the new pref Bug 28373: Add warning if custom stylesheets are defined This patch adds a check of the current XSLT prefs and warns to check the new pref if any are not set to default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124496&action=edit Bug 28373: (follow-up) Fix copy error Previous commit linked all 'default' buttons for sysprefs to OPACXSLTListsDisplay This adjusts the links To test: Click "default" for all 6 XSLT preferences Confirm the syspref relating to the link is marked 'modified' when clicked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.04 released in| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last patch needed in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #41 from Fridolin Somers <fridolin.somers@biblibre.com> --- Big change, I prefer not push to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124686&action=edit Bug 28373: [21.05] Fix transformMARCXML4XSLT export in C4::XSLT # Failed test 'use Koha::OAI::Server::Repository;' # at t/00-load.t line 62. # Tried to use 'Koha::OAI::Server::Repository'. # Error: "transformMARCXML4XSLT" is not exported by the C4::XSLT module # Can't continue after import errors at /kohadevbox/koha/Koha/OAI/Server/Repository.pm line 39. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #38)
Created attachment 124496 [details] [review] Bug 28373: (follow-up) Fix copy error
Previous commit linked all 'default' buttons for sysprefs to OPACXSLTListsDisplay
This adjusts the links
To test: Click "default" for all 6 XSLT preferences Confirm the syspref relating to the link is marked 'modified' when clicked
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, it looks like you left the atomic update file / forgot moving it to updatedatabase.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23407 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31020 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020 [Bug 31020] PassItemMarcToXSLT only applies on results pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31021 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #45 from David Cook <dcook@prosentient.com.au> --- I think that this system preference's name and description are very inaccurate... but that's for another day... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #46 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Cook from comment #45)
I think that this system preference's name and description are very inaccurate... but that's for another day... Be aware of Bug 31020
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 [Bug 32648] Search.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org