[Bug 37036] New: Cannot access template toolkit branch variable in auto renewal notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Bug ID: 37036 Summary: Cannot access template toolkit branch variable in auto renewal notices Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Set up autorenewals bu adjusting circulation rules: 'Automatic renewal' -> 'Yes' 'No automatic renewal before' -> 5 2. Set 'AutoRenewalNotices' to 'according to patron messaging preferences'. 3. Set an AUTO_RENEWALS and AUTO_RENEWALS_DGST notice to include branch info. I am using this to test: Branchcode: [% branch.branchcode %] Branch name: [% branch.branchname %] Branch address: [% branch.branchaddress1 %] Branch address2: [% IF branch.branchaddress2 %][% branch.branchaddress2 %][% END %] Branch city: [% branch.branchcity %], [% branch.branchstate %] [% branch.branchzip %] 4. Make sure your branch has the proper infro. filled out in Libraries administration. 5. Find a patron and adjust the messaging preferences so they receive automatic renewal notices. Also make sure the patron has an email. 5. Check out some items and make them due with the next 5 days. 6. Run the automatic_renewal cron job: perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v 7. Notice no branch information displays. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167458&action=edit Bug 37036: Pass along the branches table for auto renewals To test: 1. Set up autorenewals bu adjusting circulation rules: 'Automatic renewal' -> 'Yes' 'No automatic renewal before' -> 5 2. Set 'AutoRenewalNotices' to 'according to patron messaging preferences'. 3. Set an AUTO_RENEWALS and AUTO_RENEWALS_DGST notice to include branch info. I am using this to test: Branchcode: [% branch.branchcode %] Branch name: [% branch.branchname %] Branch address: [% branch.branchaddress1 %] Branch address2: [% IF branch.branchaddress2 %][% branch.branchaddress2 %][% END %] Branch city: [% branch.branchcity %], [% branch.branchstate %] [% branch.branchzip %] 4. Make sure your branch has the proper infro. filled out in Libraries administration. 5. Find a patron and adjust the messaging preferences so they receive automatic renewal notices. Also make sure the patron has an email. 5. Check out some items and make them due with the next 5 days. 6. Run the automatic_renewal cron job: perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v 7. Notice no branch information displays. 8. APPLY PATCH 9. Checkout items from multiple issuing branches to a single patron. 10. Make sure the patron's messaging prefs are set to revieve NON-digestable notices. 11. Run the automatic renewal job, each notice should include the branch information from the issuing library. 12. Change the patron's messageing preferences to receieve digestable notices. 13. Run the job without the --digest-per-branch flag. You should get a single notice with the branch info. coming from the patron's home branch. 14. Run the job with the --digest-per-branch flag. You should get seperate digested notices with the branch info. coming from the issueing library branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167458|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167503&action=edit Bug 37036: Pass along the branches table for auto renewals To test: 1. Set up autorenewals bu adjusting circulation rules: 'Automatic renewal' -> 'Yes' 'No automatic renewal before' -> 5 2. Set 'AutoRenewalNotices' to 'according to patron messaging preferences'. 3. Set an AUTO_RENEWALS and AUTO_RENEWALS_DGST notice to include branch info. I am using this to test: Branchcode: [% branch.branchcode %] Branch name: [% branch.branchname %] Branch address: [% branch.branchaddress1 %] Branch address2: [% IF branch.branchaddress2 %][% branch.branchaddress2 %][% END %] Branch city: [% branch.branchcity %], [% branch.branchstate %] [% branch.branchzip %] 4. Make sure your branch has the proper infro. filled out in Libraries administration. 5. Find a patron and adjust the messaging preferences so they receive automatic renewal notices. Also make sure the patron has an email. 5. Check out some items and make them due with the next 5 days. 6. Run the automatic_renewal cron job: perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v 7. Notice no branch information displays. 8. APPLY PATCH 9. Checkout items from multiple issuing branches to a single patron. 10. Make sure the patron's messaging prefs are set to revieve NON-digestable notices. 11. Run the automatic renewal job, each notice should include the branch information from the issuing library. 12. Change the patron's messageing preferences to receieve digestable notices. 13. Run the job without the --digest-per-branch flag. You should get a single notice with the branch info. coming from the patron's home branch. 14. Run the job with the --digest-per-branch flag. You should get seperate digested notices with the branch info. coming from the issueing library branch. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167503|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167551&action=edit Bug 37036: Pass along the branches table for auto renewals To test: 1. Set up autorenewals bu adjusting circulation rules: 'Automatic renewal' -> 'Yes' 'No automatic renewal before' -> 5 2. Set 'AutoRenewalNotices' to 'according to patron messaging preferences'. 3. Set an AUTO_RENEWALS and AUTO_RENEWALS_DGST notice to include branch info. I am using this to test: Branchcode: [% branch.branchcode %] Branch name: [% branch.branchname %] Branch address: [% branch.branchaddress1 %] Branch address2: [% IF branch.branchaddress2 %][% branch.branchaddress2 %][% END %] Branch city: [% branch.branchcity %], [% branch.branchstate %] [% branch.branchzip %] 4. Make sure your branch has the proper infro. filled out in Libraries administration. 5. Find a patron and adjust the messaging preferences so they receive automatic renewal notices. Also make sure the patron has an email. 5. Check out some items and make them due with the next 5 days. 6. Run the automatic_renewal cron job: perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v 7. Notice no branch information displays. 8. APPLY PATCH 9. Checkout items from multiple issuing branches to a single patron. 10. Make sure the patron's messaging prefs are set to revieve NON-digestable notices. 11. Run the automatic renewal job, each notice should include the branch information from the issuing library. 12. Change the patron's messageing preferences to receieve digestable notices. 13. Run the job without the --digest-per-branch flag. You should get a single notice with the branch info. coming from the patron's home branch. 14. Run the job with the --digest-per-branch flag. You should get seperate digested notices with the branch info. coming from the issueing library branch. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Looks good, and QA tests pass. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|normal |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please update the table on the wiki please? At the moment it's the best documentation we have (although I think it needs other updates as well): https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Variables... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the automatic release notes| |renewal notices | |(AUTO_RENEWALS and | |AUTO_RENEWALS_DGST) | |generated using the | |misc/cronjobs/automatic_ren | |ewals.pl cron job so that | |library information from | |the branches table is now | |available. Examples of use: | |[% branch.branchcode %], [% | |branch.branchname %], [% | |branch.branchaddress1 %], | |[% IF branch.branchaddress2 | |%][% branch.branchaddress2 | |%][% END %], [% | |branch.branchcity %], [% | |branch.branchstate %], [% | |branch.branchzip %]. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
Can you please update the table on the wiki please? At the moment it's the best documentation we have (although I think it needs other updates as well):
https://wiki.koha-community.org/wiki/ Notices_with_Template_Toolkit#Variables_available_in_each_notice
Added something to the wiki, still needs adjustment: https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37036 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org