[Bug 35423] New: AuthoritiesMarc: Warnings substr outside of string and Use of uninitialized value $type in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Bug ID: 35423 Summary: AuthoritiesMarc: Warnings substr outside of string and Use of uninitialized value $type in string eq Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org In full: substr outside of string at /usr/share/koha/C4/AuthoritiesMarc.pm line 1041. Use of uninitialized value $type in string eq at /usr/share/koha/C4/AuthoritiesMarc.pm line 1044. May be found in your logs (depending on data) when calling SearchAuthorities. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 188258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188258&action=edit Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Keywords| |Academy --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Tip to recreate for tester, using KTD: Go to http://localhost:8081/cgi-bin/koha/authorities/detail.pl?authid=1630 Edit record Go to 400 tab and add "n" to 400$w In your commandline, watch the log by running tail -f /var/log/koha/kohadev/plack-intranet-error.log Then go to Authorities and do a main heading search for "a" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Harrison Hawkins <harrisonhawkins@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Harrison Hawkins <harrisonhawkins@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188258|0 |1 is obsolete| | --- Comment #3 from Harrison Hawkins <harrisonhawkins@catalyst.net.nz> --- Created attachment 191831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191831&action=edit Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Harrison, it looks like you meant to sign this off, but your sign-off line is missing from the patch. If you use ktd you can fix this by: - Create a branch and apply the patch - git so 1 - git bz attach 35432 HEAD You might also want to check what the sign-off line looks like to verify your email and name are set up as you want it :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Harrison Hawkins <harrisonhawkins@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191831|0 |1 is obsolete| | --- Comment #5 from Harrison Hawkins <harrisonhawkins@catalyst.net.nz> --- Created attachment 191837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191837&action=edit Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged Signed-off-by: Harrison Hawkins <harrisonhawkins@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Quick! Back to this one.... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191837|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191842&action=edit Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged Signed-off-by: Harrison Hawkins <harrisonhawkins@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35423 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |RESOLVED --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is minor, lets skip backport to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org