[Bug 22652] New: Editing Course reserves is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Bug ID: 22652 Summary: Editing Course reserves is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- When editing a course reserve item, the changed values don't always show correctly in the pull downs (holding library for me). Also, the values show as (unchanged) and the new value as previous value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 [Bug 22630] Allow to change homebranch in course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 87752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87752&action=edit BUG 22652- Editing Course reserves is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I'm not really used to create patches and I've done this one on a 17.11.13 koha version. But it corrects this issue in our install. Sonia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87756&action=edit Bug 22652 - Editing Course reserves is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I don't think this patch is working in master, but I'm not sure I'm understanding the bug correctly. I've reattached the patch in a corrected format so that someone else can take a look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 --- Comment #5 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Thanks Owen! I've tested it on a sandbox and it works :) But, it's perhaps better if someone else sign it off. You could follow this test plan : 1. Create a course reserve or go on an existing one 2. Add items and add a change for the holdingbranch 3. On the list of items in this course reserve (course_reserves/course-details.pl?course_id=xx), click on "edit" at the end of a row :
without the patch, you can't see the holdingbranch you have choose for this item, but you see "LEAVE UNCHANGED" with the patch, you can see the holdingbranch you have choose when adding this item in the course
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87756|0 |1 is obsolete| | --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87763&action=edit Bug 22652 - Editing Course reserves is broken Signed-off-by: Liz Rea <wizzyrea@gmail.com> I saw the problem, patch resolves it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Status|Needs Signoff |Signed Off --- Comment #7 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Looks like Liz signed this off, changing status to Signed Off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |koha@univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87763|0 |1 is obsolete| | --- Comment #8 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 87936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87936&action=edit Bug 22652 - Editing Course reserves is broken Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87936|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 87968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87968&action=edit Bug 22652 - Editing Course reserves is broken To test: 1. Create a course reserve or go on an existing one 2. Add items and add a change for the holdingbranch 3. On the list of items in this course reserve (course_reserves/course-details.pl?course_id=xx), click on "edit" at the end of a row : Without the patch, you can't see the holdingbranch you have choose for this item, but you see "LEAVE UNCHANGED" With the patch, you can see the holdingbranch you have choose when adding this item in the course Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that fixes part of the problem I saw - will retest and file separate bugs if necessary later. Thx Sonia! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Depends on| |10382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 [Bug 10382] collection and location not returning to null when removed from course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00, 18.11.05 |19.05.00, 18.11.05, released in| |18.05.12, 17.11.18 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org