[Bug 26280] New: Add unique IDs or class names for each condition in returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Bug ID: 26280 Summary: Add unique IDs or class names for each condition in returns.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In returns.tt there are a lot of conditionals that can possibility happen when checking in items, many of these have the common class of 'problem'. I would be nice if each one had a unique ID or class name so they could be specifically targeted for audio alerts. Examples: Not for loan status updated. Item is lost, cannot be checked in. And so on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- "I would be nice if each had a unique name" but also "It would be nice" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Wait, I didn't realize I can use jQuery selectors here. So this works: .problem:contains("Not for loan status updated") Marking this as invalid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I'm reopening this because I think a simpler selector would be a good idea. Having an open bug doesn't hurt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 109774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109774&action=edit Bug 26280: Add unique class for each problem in returns.tt This patch adds a 2nd unique class to each of the checkin 'problems' 1. Checkin an item with a bad barcode and see the prolem class also has a class called 'badbarcode' 2. Checkin an item that triggers a lotforloan updated via UpdateNotForLoanStatusOnCheckin, notice the class 'nfl_update'. 3. You should also see an updated_from and updated_to class. This should make it easier to target those for audio alerts 4. Checkin an item that triggers an location update and see the class 'location_update' 5. Checkin an item that is not at its permenat location and you should see the class 'ispermenant'. 6. Checkin an item that is not checkout and you should see the class 'notissued' 7. Checkin lost items with BlockReturnOfLostItems set to 'Dont block' and see the class 'itemlost_checkedin' 8 Checkin lost items with BlockReturnOfLostItems set to 'block' and see the class 'itemlost_blocked' 9. Checkin lost items with a fee on the patron's account for that lost item and see the class 'fee_remains' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I think to make it less likely that these classes collide with classes defined elsewhere in Koha they should have a common prefix. "ret_badbarcode" or something like that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109774|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 110413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110413&action=edit Bug 26280: Add unique class for each problem in returns.tt 1. Checkin an item with a bad barcode and see the prolem class also has a class called 'ret_badbarcode' 2. Checkin an item that triggers a lotforloan updated via UpdateNotForLoanStatusOnCheckin, notice the class 'ret_nflupdate'. 3. You should also see an updated_from and updated_to class. This should make it easier to target those for audio alerts 4. Checkin an item that triggers an location update and see the class 'ret_locationupdate' 5. Checkin an item that is not at its permenat location and you should see the class 'ret_ispermenant'. 6. Checkin an item that is not checkout and you should see the class 'ret_notissued' 7. Checkin lost items with BlockReturnOfLostItems set to 'Dont block' and see the class 'ret_checkedin' 8 Checkin lost items with BlockReturnOfLostItems set to 'block' and see the class 'ret_blocked' 9. Checkin lost items with a fee on the patron's account for that lost item and see the class 'ret_feeremains' 10. Checkin item that is withdrawn and see the class 'ret_withdrawn' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110413|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110601&action=edit Bug 26280: Add unique class for each problem in returns.tt 1. Checkin an item with a bad barcode and see the prolem class also has a class called 'ret_badbarcode' 2. Checkin an item that triggers a lotforloan updated via UpdateNotForLoanStatusOnCheckin, notice the class 'ret_nflupdate'. 3. You should also see an updated_from and updated_to class. This should make it easier to target those for audio alerts 4. Checkin an item that triggers an location update and see the class 'ret_locationupdate' 5. Checkin an item that is not at its permenat location and you should see the class 'ret_ispermenant'. 6. Checkin an item that is not checkout and you should see the class 'ret_notissued' 7. Checkin lost items with BlockReturnOfLostItems set to 'Dont block' and see the class 'ret_checkedin' 8. Checkin lost items with BlockReturnOfLostItems set to 'block' and see the class 'ret_blocked' 9. Checkin lost items with a fee on the patron's account for that lost item and see the class 'ret_feeremains' 10. Checkin item that is withdrawn and see the class 'ret_withdrawn' Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110601|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110612&action=edit Bug 26280: Add unique class for each problem in returns.tt 1. Checkin an item with a bad barcode and see the prolem class also has a class called 'ret_badbarcode' 2. Checkin an item that triggers a lotforloan updated via UpdateNotForLoanStatusOnCheckin, notice the class 'ret_nflupdate'. 3. You should also see an updated_from and updated_to class. This should make it easier to target those for audio alerts 4. Checkin an item that triggers an location update and see the class 'ret_locationupdate' 5. Checkin an item that is not at its permenat location and you should see the class 'ret_ispermenant'. 6. Checkin an item that is not checkout and you should see the class 'ret_notissued' 7. Checkin lost items with BlockReturnOfLostItems set to 'Dont block' and see the class 'ret_checkedin' 8. Checkin lost items with BlockReturnOfLostItems set to 'block' and see the class 'ret_blocked' 9. Checkin lost items with a fee on the patron's account for that lost item and see the class 'ret_feeremains' 10. Checkin item that is withdrawn and see the class 'ret_withdrawn' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org