[Bug 36589] New: Advanced cataloging - Expand clipboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Bug ID: 36589 Summary: Advanced cataloging - Expand clipboard Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl I was updating the screenshots for the manual in the advanced editor section and noticed the clipboard is very small compared to before. I don't use the advanced cataloging editor, so I don't know if it's a need for the clipboard to be large or small, but just clicking around, I find it hard to use with it being so small. See the "before" screenshot: https://koha-community.org/manual/23.05/en/html/_images/advancedcataloging.p... To get there: 1. Enable the EnableAdvancedCatalogingEditor syspref 2. Search the catalog for a record 3. Click Edit > Edit record 4. Toggle the editor to the advanced editor 5. Click on the content of a field and press Ctrl+C --> The field should be added to the clipboard section on the left side 6. Redo step 5 a couple of times --> All the fields are added to the clipboard section on the left side, but only 1.5ish lines are shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I searched a bit in bugzilla and didn't find a bug that made the clipboard small, so I think it might be an unexpected side effect of the redesign or of another change... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Sorry, me again. I normally test in Chrome, and I see 1.5ish lines in Chrome. But I just tried in Firefox and I find it worst. Only one line is shown in Firefox and there are no arrows to indicate that there actually are more than one line in the clipboard. "Before" picture: https://koha-community.org/manual/23.05/en/html/_images/advancedcataloging.p... My current clipboard in Chrome, with 3 fields copied into the clipboard: https://snipboard.io/E1DTjA.jpg My current clipboard in Firefox, with 3 fields copied into it: https://snipboard.io/dRFVOI.jpg I use Ubuntu 22.04 with Chrome 123.0.6312.105 and Firefox is 124.0.1, if it's relevant. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |phil@chetcolibrary.org --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Chances are it has been that way since 21.05, from bug 21851 adding https://git.koha-community.org/Koha-community/Koha/src/commit/1ea4a11c2a88f7... though that might have only wound up applying after some other later change (or even after a browser change in how to deal with the combination of <select size="10" style="height: calc(1.5em + .75rem + 2px);"> which is what the HTML plus the CSS amount to). As the attempt to fix it in bug 27769 by just removing .brief from the parent fieldset shows, it does need to have the width: 100% it gets from fieldset.brief select so it doesn't start out with no width and grow to the width of any line copied into it, but it needs to avoid that one-line height. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced cataloging - |Advanced cataloging - |Expand clipboard |restore the correct height | |of the clipboard Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 166856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166856&action=edit Bug 36589: Advanced cataloging - restore the correct height of the clipboard A simple direct fix for the height of the advanced editor's clipboard, which is a <select size="10"> that's currently cut down to the height of one thick line by CSS intended for non-multiple, non-sized selects with dropdown menus. Test plan: 1. Set the pref EnableAdvancedCatalogingEditor to Enable 2. Cataloging -> Advanced editor 3. Note the Clipboard is a single line tall 4. Apply patch, shift+reload Advanced editor 5. Note the Clipboard is ten lines tall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166856|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166911&action=edit Bug 36589: Advanced cataloging - restore the correct height of the clipboard A simple direct fix for the height of the advanced editor's clipboard, which is a <select size="10"> that's currently cut down to the height of one thick line by CSS intended for non-multiple, non-sized selects with dropdown menus. Test plan: 1. Set the pref EnableAdvancedCatalogingEditor to Enable 2. Cataloging -> Advanced editor 3. Note the Clipboard is a single line tall 4. Apply patch, shift+reload Advanced editor 5. Note the Clipboard is ten lines tall Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Filed bug 36897 to keep the next person to use a sized or multiple select in a sidebar from having to figure out the need to do this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166911|0 |1 is obsolete| | --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167165&action=edit Bug 36589: Advanced cataloging - restore the correct height of the clipboard A simple direct fix for the height of the advanced editor's clipboard, which is a <select size="10"> that's currently cut down to the height of one thick line by CSS intended for non-multiple, non-sized selects with dropdown menus. Test plan: 1. Set the pref EnableAdvancedCatalogingEditor to Enable 2. Cataloging -> Advanced editor 3. Note the Clipboard is a single line tall 4. Apply patch, shift+reload Advanced editor 5. Note the Clipboard is ten lines tall Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org