[Bug 19122] New: IncludeSeeFromInSearches is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Bug ID: 19122 Summary: IncludeSeeFromInSearches is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The IncludeSeeFromInSearches system preference is designed so that 'See from' headings from the authorities are included when you search in the catalog. That means that you could find an author not only by the name printed on the book, but for example also by their pseudonym or a different spelling of their name. This functionality appears to be broken on master and possibly stable versions as well. It was added by bug 7417. To test: - Activate IncludeSeeFromInSearches - Catalog an authority for a person - main heading in 100 - see from headings in 400 - Catalog a bibliographic record and link it to the authority - Make sure the record is indexed - Verify that the record can be found searching for the main heading, but not for the see from headings in the catalog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This feature is important as it makes authorities so much more useful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik@adminkuhn.ch --- Comment #2 from Michael Kuhn <mik@adminkuhn.ch> --- This functionality was definitively working in Koha 3.20.4. It is for sure broken in Koha 16.11.4 (this was a new installation, upgraded from 16.11.0) and Koha 17.05.1 (after the upgrade from Koha 3.20.4). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Jens Weber <jens.weber@phsh.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jens.weber@phsh.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |18098 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 5ef1b6710e7520b844e145e248da0deeee707fde Bug 18098: Add an index with the count of not onloan items Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098 [Bug 18098] Add an index with the count of not onloan items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67526&action=edit Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour The IncludeSeeFromInSearches system preference is designed so that 'See from' headings from the authorities are included when you search in the catalog. That means that you could find an author not only by the name printed on the book, but for example also by their pseudonym or a different spelling of their name. It was added by bug 7417. This regression has been introduced by commit 5ef1b6710e7520b844e145e248da0deeee707fde Bug 18098: Add an index with the count of not onloan items - } elsif ($record_type eq 'biblio' && C4::Context->preference('IncludeSeeFromInSearches')) { - my $normalizer = Koha::RecordProcessor->new( { filters => 'EmbedSeeFromHeadings' } ); [...] + push @filters, 'IncludeSeeFromInSearches' + if C4::Context->preference('IncludeSeeFromInSearches'); Test plan: - Activate IncludeSeeFromInSearches - Catalog an authority for a person - main heading in 100 - see from headings in 400 - Catalog a bibliographic record and link it to the authority - Make sure the record is indexed - Verify that the record can be found searching for the main heading - Verify that the record can be found searching for the see from headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Oops. Thank for taking care, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67535&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67526|0 |1 is obsolete| | Attachment #67535|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67536&action=edit Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour The IncludeSeeFromInSearches system preference is designed so that 'See from' headings from the authorities are included when you search in the catalog. That means that you could find an author not only by the name printed on the book, but for example also by their pseudonym or a different spelling of their name. It was added by bug 7417. This regression has been introduced by commit 5ef1b6710e7520b844e145e248da0deeee707fde Bug 18098: Add an index with the count of not onloan items - } elsif ($record_type eq 'biblio' && C4::Context->preference('IncludeSeeFromInSearches')) { - my $normalizer = Koha::RecordProcessor->new( { filters => 'EmbedSeeFromHeadings' } ); [...] + push @filters, 'IncludeSeeFromInSearches' + if C4::Context->preference('IncludeSeeFromInSearches'); Test plan: - Activate IncludeSeeFromInSearches - Catalog an authority for a person - main heading in 100 - see from headings in 400 - Catalog a bibliographic record and link it to the authority - Make sure the record is indexed - Verify that the record can be found searching for the main heading - Verify that the record can be found searching for the see from headings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67536|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67564&action=edit Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour The IncludeSeeFromInSearches system preference is designed so that 'See from' headings from the authorities are included when you search in the catalog. That means that you could find an author not only by the name printed on the book, but for example also by their pseudonym or a different spelling of their name. It was added by bug 7417. This regression has been introduced by commit 5ef1b6710e7520b844e145e248da0deeee707fde Bug 18098: Add an index with the count of not onloan items - } elsif ($record_type eq 'biblio' && C4::Context->preference('IncludeSeeFromInSearches')) { - my $normalizer = Koha::RecordProcessor->new( { filters => 'EmbedSeeFromHeadings' } ); [...] + push @filters, 'IncludeSeeFromInSearches' + if C4::Context->preference('IncludeSeeFromInSearches'); Test plan: - Activate IncludeSeeFromInSearches - Catalog an authority for a person - main heading in 100 - see from headings in 400 - Catalog a bibliographic record and link it to the authority - Make sure the record is indexed - Verify that the record can be found searching for the main heading - Verify that the record can be found searching for the see from headings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Yet another reason to get rid of all this functions from this script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dependency is not in 16.11.x, this does not apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #12 from Barton Chittenden <barton@bywatersolutions.com> --- Does this fix the combination of sysprefs documented in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715#c2 ? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org