[Bug 4035] New: Today's checkouts grouped with previous checkouts
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4035 Summary: Today's checkouts grouped with previous checkouts Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Circulation AssignedTo: gmcharlt@gmail.com ReportedBy: oleonard@myacpl.org Estimated Hours: 0.0 Change sponsored?: --- -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4035 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-01-11 15:26:24 --- Items checked out today should be grouped together in the display of a patron's checkouts. Items checked out previously should be grouped below under the "Previous checkouts" header. Currently, all checkouts are grouped under "previous checkouts" with the latest checkout all the way at the bottom. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4035 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2010-01-12 15:14:44 --- On line 457 of circulation.pl the item's checkout date gets formatted: $it->{'issuedate'} = format_date($it->{'issuedate'}); But then on line 464: if ( $todaysdate eq $it->{'issuedate'} or $todaysdate eq $it->{'lastreneweddate'} ) { push @todaysissues, $it; } else { push @previousissues, $it; } The script is trying to compare the now-formatted $it->{'issuedate'} to an unformatted date. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4035 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |oleonard@myacpl.org Status|NEW |ASSIGNED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2010-01-12 15:29:30 --- Created an attachment (id=1464) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1464) Proposed fix The patch creates a separate variable to be output to the template so that the original issuedate can be used in date comparison. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4035 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4035 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon@kohaorg.ec2.liblime.com