[Bug 14141] New: Changing the Library for a notice duplicates the notice instead of updating it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Bug ID: 14141 Summary: Changing the Library for a notice duplicates the notice instead of updating it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If you edit a notice for a library and choose to change the Library field, the notice is created for that library, but the old notice remains. Essentially this turns the "update" into a "copy with edits". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40987&action=edit Bug 14141: Do not let edit the branch when updating/copying notice If a user modify the library when he's updating a notice, the notice will be duplicated, instead of modified. To reproduce: 1/ Go on the notice & slips tools (tools/letter.pl) 2/ Create a notice A for library L1 3/ Edit this notice and update the library with L2 4/ On the list view, you will observe that 2 notices A now exist, one for L1 and one for L2. The code in tools/letters.pl should be rebuilt completely, it becomes a house of cards. To prevent this bug, I suggest to not let the user modify the library value on editing a notice. It cans be done by copying the notice to another library and remove the original one. Counter patch welcomed. Test plan: 1/ Go on the notice & slips tools (tools/letter.pl). 2/ Create a notice A for library L1. 3/ Edit this notice: you are not able to modify the library anymore. 4/ Copy the notice to library L2. You are not able to modify the library neither. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 41076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41076&action=edit Bug 14141: Do not let edit the branch when updating/copying notice Works ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40987|0 |1 is obsolete| | Attachment #41076|0 |1 is obsolete| | --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 41077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41077&action=edit Bug 14141: Do not let edit the branch when updating/copying notice Works ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ugh - this sounds quite annoying when you accidentally set the wrong library. But the duplicateing is also bad :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This doesn't work for me: 1) Copy an 'all libraries' notice to another branch 2) Try to save it: A letter with the code 'DUE' already exists for 'undefined'. Can you check? I had to resolve a conflict, maybe I got that wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42769&action=edit Bug 14141: Fix copy action Test plan: Try to copy a letter to a library which already have this letter (same letter_code) defined. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41077|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 42966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42966&action=edit Bug 14141: Do not let edit the branch when updating/copying notice If a user modify the library when he's updating a notice, the notice will be duplicated, instead of modified. To reproduce: 1/ Go on the notice & slips tools (tools/letter.pl) 2/ Create a notice A for library L1 3/ Edit this notice and update the library with L2 4/ On the list view, you will observe that 2 notices A now exist, one for L1 and one for L2. The code in tools/letters.pl should be rebuilt completely, it becomes a house of cards. To prevent this bug, I suggest to not let the user modify the library value on editing a notice. It cans be done by copying the notice to another library and remove the original one. Counter patch welcomed. Test plan: 1/ Go on the notice & slips tools (tools/letter.pl). 2/ Create a notice A for library L1. 3/ Edit this notice: you are not able to modify the library anymore. 4/ Copy the notice to library L2. You are not able to modify the library neither. Works ok. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42769|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 42967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42967&action=edit Bug 14141: Fix copy action Test plan: Try to copy a letter to a library which already have this letter (same letter_code) defined. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42966|0 |1 is obsolete| | Attachment #42967|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42983&action=edit [PASSED QA] Bug 14141: Do not let edit the branch when updating/copying notice If a user modify the library when he's updating a notice, the notice will be duplicated, instead of modified. To reproduce: 1/ Go on the notice & slips tools (tools/letter.pl) 2/ Create a notice A for library L1 3/ Edit this notice and update the library with L2 4/ On the list view, you will observe that 2 notices A now exist, one for L1 and one for L2. The code in tools/letters.pl should be rebuilt completely, it becomes a house of cards. To prevent this bug, I suggest to not let the user modify the library value on editing a notice. It cans be done by copying the notice to another library and remove the original one. Counter patch welcomed. Test plan: 1/ Go on the notice & slips tools (tools/letter.pl). 2/ Create a notice A for library L1. 3/ Edit this notice: you are not able to modify the library anymore. 4/ Copy the notice to library L2. You are not able to modify the library neither. Works ok. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42984&action=edit [PASSED QA] Bug 14141: Fix copy action Test plan: Try to copy a letter to a library which already have this letter (same letter_code) defined. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #13 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org