[Bug 9937] New: Routines introduced for creating a subscription from an order need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Bug ID: 9937 Summary: Routines introduced for creating a subscription from an order need unit tests. Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|master |3.12 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5343 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16934&action=edit Bug 9937: Add new unit tests for new routines (introduced by bug 5343) New unit tests for 4 routines: - C4::Serials::subscriptionCurrentlyOnOrder - C4::Acquisition::GetLastOrderNotReceivedFromSubscriptionid - C4::Acquisition::GetLastOrderReceivedFromSubscriptionid - C4::Budgets::GetBudgetName -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16934|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17015&action=edit Bug 9937: Add new unit tests for new routines (introduced by bug 5343) New unit tests for 4 routines: - C4::Serials::subscriptionCurrentlyOnOrder - C4::Acquisition::GetLastOrderNotReceivedFromSubscriptionid - C4::Acquisition::GetLastOrderReceivedFromSubscriptionid - C4::Budgets::GetBudgetName Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.12 |master QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17015|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17053&action=edit [PASSED QA] Bug 9937: Add new unit tests for new routines (introduced by bug 5343) New unit tests for 4 routines: - C4::Serials::subscriptionCurrentlyOnOrder - C4::Acquisition::GetLastOrderNotReceivedFromSubscriptionid - C4::Acquisition::GetLastOrderReceivedFromSubscriptionid - C4::Budgets::GetBudgetName Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a tab in t/db/dependent/Budgets.t All tests, new db_dependent tests and QA script pass. Thx Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9937 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. I was unable to run the unit tests on my server due to database breakage, but Chris and Katrin report it working and today that's enough. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org