[Bug 18859] New: Warns when accessing Circulation -> Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Bug ID: 18859 Summary: Warns when accessing Circulation -> Holds Queue Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Viewing the holds queue triggers the following warns: The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. The method description is not covered by tests at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/view_holdsqueue.pl line 69. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 64666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64666&action=edit Bug 18859: Prevent warns when viewing holds queue The code was using $itemtypes->description instead of $itemtype->description. To test: 1) View the intranet log 2) Go to Circulation -> Holds queue 3) Notice the warns 4) Apply patch and refresh page 5) Warns should not appear and item types should still display as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64666|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 64725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64725&action=edit Bug 18859: Prevent warns when viewing holds queue The code was using $itemtypes->description instead of $itemtype->description. To test: 1) View the intranet log 2) Go to Circulation -> Holds queue 3) Notice the warns 4) Apply patch and refresh page 5) Warns should not appear and item types should still display as expected Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 [Bug 18881] Use translated description in itemtype circ/view_holdsqueue.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |RESOLVED --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Good catch, Aleisha. I am moving the solution to 18881 as Marc expanded it. *** This bug has been marked as a duplicate of bug 18881 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18881 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 [Bug 18881] Remove dead code in circ/view_holdsqueue.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org