[Bug 43738] New: Notice module "Reports" label is unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 Bug ID: 43738 Summary: Notice module "Reports" label is unclear Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk Depends on: 34136 Target Milestone: --- Bug 34136 added the notice module "Reports" for templates to be used when rendering reports data for viewing in the staff interface. Bug 38621 is based on an assumption that the Reports notice module is to be used for templates for use with the patron emailer cronjob added in Bug 16149. The patron emailer cron can use a notice template from any module, so making your notice in the Reports module isn't a problem for the cron. However, a template that works correctly with the patron emailer cron will not work correctly when rendering reports data using the "Run with template" option from Bug 34136. The patron emailer is expected to generate one notice per row of the report results while the "Run with template" functionality is expected to apply the template to all rows of the report results. So creating patron emailer templates in the reports module clutters the "Run with template" dropdown with options that will not work as desired. We should make the label on the Report notice module more clearly convey that it is meant for rendering report results in the staff interface. Maybe a parenthetical, as we have with "Patrons (Custom slip)" and "Patrons (Custom message)." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 [Bug 34136] Add ability to render a report using a notice template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207377&action=edit But 43738: Clarify label on Reports module in notices To test: 1 - Create a new notice in with modlue="Reports" 2 - Apply patch, restart services 3 - go to Tools, then Notices and Slips 4 - find your template in the list of notices, confirm it now shows module="Reports (custom diplay)" 5 - Click "New notice," confirm the dropdown options include "Reports (custom diplay)" 6 - Create or edit a notice, confirm the Modules dropdown includes "Reports (custom diplay)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207380&action=edit But 43738: Clarify label on Reports module in notices To test: 1 - Create a new notice in with modlue="Reports" 2 - Apply patch, restart services 3 - go to Tools, then Notices and Slips 4 - find your template in the list of notices, confirm it now shows module="Reports (custom diplay)" 5 - Click "New notice," confirm the dropdown options include "Reports (custom diplay)" 6 - Create or edit a notice, confirm the Modules dropdown includes "Reports (custom diplay)" Signed-off-by: Rae Schumann <rschumann@utah.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 --- Comment #3 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 207491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207491&action=edit But 43738: Clarify label on Reports module in notices To test: 1 - Create a new notice in with modlue="Reports" 2 - Apply patch, restart services 3 - go to Tools, then Notices and Slips 4 - find your template in the list of notices, confirm it now shows module="Reports (custom diplay)" 5 - Click "New notice," confirm the dropdown options include "Reports (custom diplay)" 6 - Create or edit a notice, confirm the Modules dropdown includes "Reports (custom diplay)" Signed-off-by: Rae Schumann <rschumann@utah.gov> Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jvinke@austinseminary.edu QA Contact|testopia@bugs.koha-communit |jvinke@austinseminary.edu |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 207809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207809&action=edit Bug 43738: Clarify label on Reports module in notices To test: 1 - Create a new notice in with modlue="Reports" 2 - Apply patch, restart services 3 - go to Tools, then Notices and Slips 4 - find your template in the list of notices, confirm it now shows module="Reports (custom diplay)" 5 - Click "New notice," confirm the dropdown options include "Reports (custom diplay)" 6 - Create or edit a notice, confirm the Modules dropdown includes "Reports (custom diplay)" PA amended commit title 'But' -> 'Bug' Signed-off-by: Rae Schumann <rschumann@utah.gov> Signed-off-by: John Vinke <jvinke@austinseminary.edu> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43738 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org