[Bug 22580] New: Remove misc/cronjobs/delete_expired_opac_registrations.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Bug ID: 22580 Summary: Remove misc/cronjobs/delete_expired_opac_registrations.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- misc/cronjobs/delete_expired_opac_registrations.pl states within it that the script is deprecated in favour of using clean_database.pl with a flag. The deprecation message was added back in October 2014.. I think sufficient time has passed such that we can remove this script now ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22465 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22465 [Bug 22465] PatronSelfRegistrationExpireTemporaryAccountsDelay should recommend cleanup_database.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22465 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Bug 22580 depends on bug 22465, which changed state. Bug 22465 Summary: PatronSelfRegistrationExpireTemporaryAccountsDelay should recommend cleanup_database.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22465 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove |Remove deprecated |misc/cronjobs/delete_expire |delete_expired_opac_registr |d_opac_registrations.pl |ations.pl cronjob Component|Architecture, internals, |Command-line Utilities |and plumbing | Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | CC| |katrin.fischer@bsz-bw.de, | |robin@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The functionality of release notes| |delete_expired_opac_registr | |ations.pl was moved into | |the cleanup_database.pl | |cronjob. Please make sure | |to adjust your conjob | |configuration accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87690&action=edit Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob Removes the deprecated script and changes the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference. To test: - Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl was deleted - Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is correct - Make sure there are no other reference to the removed script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As we remove the other related script in this release, it would make sense to remove this one in 19.05 as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21855 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87690|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87726&action=edit Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob Removes the deprecated script and changes the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference. To test: - Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl was deleted - Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is correct - Make sure there are no other reference to the removed script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- +1 Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Going to go straight for a PQA on this one.. no references found anywhere and it's a simple removal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87728&action=edit Bug 22680: OPAC language footer not positioned correctly This patch modifies the OPAC CSS so that the language-selection footer is positioned correctly. To test, apply the patch and rebuild the OPAC CSS. - Enable one or more translations in the OPAC - View a page in the OPAC which can display in your browser without a vertical scrollbar (for instance, the OPAC main page with no news items or OpacMainUserBlock). - The language-selection footer should appear at the bottom of the screen. At smaller browser heights the footer should scroll offscreen. - Test with content in the opaccredits system preference, and with OpacKohaUrl enabled. The footer should still be positioned correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org