[Bug 30215] New: "Item found" in accountlines untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30215 Bug ID: 30215 Summary: "Item found" in accountlines untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr When a lost item is returned and refunded to the patron, the accountline description contains "Item found" which is untranslatable. To generate this accountline: 0- Make sure BlockReturnOfLostItems is set to Don't Block 0- Make sure WhenLostChargeReplacementFee is set to Charge 0- In Circulation rules, make sure Default lost item fee refund on return policy is set to one of the Refund options 0- Make sure your item has a replacement price (field v of the item) 1- Check out the item to a patron 2- Change the status of the item to lost The patron should be charged the replacement price 3- Check in the item The patron should have a new credit Lost item fee refund In the description of this new credit, it says "Item found <itemnumber>". I couldn't find "Item found" anywhere in the po files. In fact, when I git grep it, it only shows up in C4/Items. (Also, I'm wondering if the itemnumber is really useful here, I think it will confuse library staff as I myself was confused, but this is not the point of this bug) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30215 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem is here: my $credit; if ( $credit_total > 0 ) { my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; $credit = $account->add_credit( { amount => $credit_total, description => 'Item found ' . $self->itemnumber, type => 'LOST_FOUND', interface => C4::Context->interface, library_id => $branchcode, item_id => $self->itemnumber, issue_id => $lost_charge->issue_id } ); Having the description option seems to be a bad idea in the first place when it's not used for adding variables like the title, due date etc. Always meant trouble for translations. I also agree about the itemnumber not being useful. We do have the link to the item displaying in the table, there is no need for it in the description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30215 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I was coming to bugzilla to file this again! The faulty line was moved from C4/Items.pm to Koha/Item.pm. It appears twice in that file https://git.koha-community.org/Koha-community/Koha/src/commit/c355bb8574f62e... my $credit; if ( $credit_total > 0 ) { my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; $credit = $account->add_credit( { amount => $credit_total, description => 'Item found ' . $self->itemnumber, type => 'LOST_FOUND', interface => C4::Context->interface, library_id => $branchcode, item_id => $self->itemnumber, issue_id => $lost_charge->checkout ? $lost_charge->checkout->issue_id : undef, } ); https://git.koha-community.org/Koha-community/Koha/src/commit/c355bb8574f62e... my $credit; if ( $credit_total > 0 ) { my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; $credit = $account->add_credit( { amount => $credit_total, description => 'Item found ' . $self->itemnumber, type => 'PROCESSING_FOUND', interface => C4::Context->interface, library_id => $branchcode, item_id => $self->itemnumber, issue_id => $processing_charge->checkout ? $processing_charge->checkout->issue_id : undef, } ); I would remove it myself, but I was told years ago that a change to a .pm file required tests and I don't know how to write those... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org