[Bug 6829] New: Remove two warnings for opac-MARCdetail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Bug #: 6829 Summary: Remove two warnings for opac-MARCdetail Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: koha-bugs@lists.koha-community.org Remove this warning by adding a check: [Thu Sep 01 14:20:18 2011] [error] [client 192.87.126.61] [Thu Sep 1 14:20:18 2011] opac-MARCdetail.pl: Use of uninitialized value in string ne at /usr/share/koha/testclone/opac/opac-MARCdetail.pl line 145., referer: http://libdevelop.rijksmuseum.nl:8008/cgi-bin/koha/opac-detail.pl?biblionumb... And this warning: [Mon Aug 29 13:58:02 2011] [error] [client 66.249.72.86] [Mon Aug 29 13:58:02 2011] opac-MARCdetail.pl: Use of uninitialized value in string comparison (cmp) at /usr/share/koha/prodclone/opac/opac-MARCdetail.pl line 238. This warning is still generated in 3.3.0.12, but could be resolved in 3.5 with the removing of 952 from marcxml. The check does not hurt however. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-01 12:36:59 UTC --- Created attachment 5253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5253 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5253|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-01 12:38:01 UTC --- Created attachment 5254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5254 Patch Oops. Submitted the wrong file. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-01 12:41:31 UTC --- Test: Check your logfile for the error on line 145. After you applied the patch, run opac-MARCdetail again for that record; you should not receive the warning again in the logfile for that biblionumber. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 12:52:39 UTC --- Still getting one error in the log: opac-MARCdetail.pl: Use of uninitialized value in string ne at /kohaclone/opac/opac-MARCdetail.pl line 218. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5254|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-01 13:05:30 UTC --- Created attachment 5255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5255 Revised patch Clearing warning from Owen too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5255|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-01 13:08:23 UTC --- Created attachment 5256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5256 Revised patch improved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5256|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 13:13:44 UTC --- Created attachment 5257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5257 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-14 10:23:06 UTC --- Simple fix to remove warns, pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 --- Comment #9 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:11 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Patch Status|Patch Pushed |Failed QA --- Comment #10 from Frédéric Demians <frederic@tamil.fr> 2011-12-27 09:26:16 UTC --- With this patch, opac-MARCdetail.pl doesn't display anymore subfields which 'hidden' parameter is set to 0. Reverting this patch solves the issue. But I will send a follow-up patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 --- Comment #11 from Frédéric Demians <frederic@tamil.fr> 2011-12-27 10:19:58 UTC --- Created attachment 6931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6931 Follow up patch To reproduce the bug: - Open OPAC MARC View for a specific biblio record - Fields which are affected to tab 0 are all hidden -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5257|0 |1 is obsolete| | Attachment #6931|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-04 06:49:21 UTC --- Created attachment 7035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7035 [SIGNED-OFF] Bug 6829 Follow up patch To reproduce the bug: - Open OPAC MARC View for a specific biblio record - Fields which are affected to tab 0 are all hidden Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes bug for 0xx fields in OPAC MARC view. Note: the problem only exists for 0xx fields with real subfields, control fields display correctly, fields like 040 only display after patch was applied. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #13 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-05 13:03:51 UTC --- Simple one line change, replacing a '' with 0 (which is more explicitly correct in this case) and ne with !=. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Signed Off --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-05 13:05:15 UTC --- (In reply to comment #13)
Simple one line change, replacing a '' with 0 (which is more explicitly correct in this case) and ne with !=. Marking as Passed QA
There is still a possible issue here (a 952 subfield). Was just looking at it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-05 13:57:32 UTC --- Created attachment 7051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7051 Second follow up Needed this second follow up to remove 952-0 from the display again, coming up after the first follow up. Changed a second test in accordance with first follow up. Removed a useless 10th loop to create a tab10XX that is not in the template. Took the liberty to sign it off myself. Small change but annoying to find. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |ian.walls@bywatersolutions. |ity.org |com --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-05 13:59:12 UTC --- Ian, If you could have a second look please. Thanks and sorry for the inconvenience.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Signed Off |Passed QA --- Comment #17 from Ian Walls <koha.sekjal@gmail.com> 2012-01-21 17:30:42 UTC --- Followup patch is straightforward change to loop size, and uses 'defined' versus variable evaluation to handle 0 case. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6829 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org