[Bug 8143] New: Upgrade jQuery tabs to current jQueryUI version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Priority: P5 - low Change sponsored?: --- Bug ID: 8143 Assignee: oleonard@myacpl.org Summary: Upgrade jQuery tabs to current jQueryUI version Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha We use a very old version of jQuery tabs in many places. Each instance should be updated to work with the latest jQueryUI. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5481 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7747 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9886&action=edit Bug 8143 - Upgrade jQuery tabs to current jQueryUI version Current jQuery-driven tabs are done using a very old version of the tabs plugin. This patch upgrades jQueryUI to the latest version and adds the tabs widget dependency to the jqueryui js file and updates the syntax for existing tabs: - $("#foo > ul").tabs(); changes to $("#foo").tabs(); - Remove full URL from tab links (use #anchor only). Pages with "static" tabs (tabs which are built in the markup rather than generated by the plugin) have been modified to use their own style. Examples: pay.tt in the staff client and opac-readingrecord.tt in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8181 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch touches a lot of files, so I thought it might be helpful to list the pages which should be checked. In this first list, these are pages which can be viewed to check changes to include files. On each of these pages the search header include was modified: acquisitions-search.inc: acqui/acqui-home.pl authorities-search.inc: authorities/authorities-home.pl budgets-admin-search.inc: admin/aqbudgetperiods.pl cat-search.inc: virtualshelves/shelves.pl cataloging-search.inc: cataloguing/addbooks.pl checkin-search.inc: circ/returns.pl circ-search.inc: circ/circulation-home.pl cities-admin-search.inc: admin/cities.pl contracts-admin-search.inc: admin/aqcontract.pl?booksellerid=1 currencies-admin-search.inc: admin/currency.pl home-search.inc: mainpage.pl letters-search.inc: tools/letter.pl patron-search.inc: members/members-home.pl patrons-admin-search.inc: admin/categorie.pl prefs-admin-search.inc: admin/preferences.pl printers-admin-search.inc: admin/printers.pl roadtype-admin-search.inc: admin/roadtype.pl serials-search.inc: serials/serials-home.pl stopwords-admin-search.inc: admin/stopwords.pl suggestions-add-search.inc: acqui/newordersuggestion.pl?booksellerid=1&basketno=1 sysprefs-admin-search.inc: admin/systempreferences.pl z3950-admin-search.inc: admin/z3950servers.pl These pages have changes to their main templates: about.pl acqui/basketgroup.pl admin/auth_subfields_structure.pl admin/authorised_values.pl admin/branch_transfer_limits.pl admin/item_circulation_alerts.pl admin/itemtypes.pl admin/marc_subfields_structure.pl authorities/authorities.pl authorities/detail.pl catalogue/MARCdetail.pl catalogue/advsearch.pl catalogue/detail.pl cataloguing/addbiblio.pl cataloguing/merge.pl circ/circulation.pl circ/waitingreserves.pl members/boraccount.pl members/mancredit.pl members/maninvoice.pl members/moremember.pl members/pay.pl members/paycollect.pl reviews/reviewswaiting.pl serials/serials-collection.pl serials/subscription-detail.pl suggestion/suggestion.pl tools/csv-profiles.pl tools/overduerules.pl virtualshelves/shelves.pl opac-advsearch.pl opac-detail.pl opac-readingrecord.pl opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9886|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9922&action=edit Bug 8143 [REVISED] Upgrade jQuery tabs to current jQueryUI version Current jQuery-driven tabs are done using a very old version of the tabs plugin. This patch upgrades jQueryUI to the latest version and adds the tabs widget dependency to the jqueryui js file and updates the syntax for existing tabs: - $("#foo > ul").tabs(); changes to $("#foo").tabs(); - Remove full URL from tab links (use #anchor only). Pages with "static" tabs (tabs which are built in the markup rather than generated by the plugin) have been modified to use their own style. Examples: pay.tt in the staff client and opac-readingrecord.tt in the OPAC. Edit: Minor revision to some uncorrected markup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Michael Davis <m.r.davis@cranfield.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.r.davis@cranfield.ac.uk --- Comment #4 from Michael Davis <m.r.davis@cranfield.ac.uk> --- error: patch failed: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:29 error: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: patch does not apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Applies cleanly to master for me... changing status to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #6 from Michael Davis <m.r.davis@cranfield.ac.uk> --- Doesn't apply if you add the 7747 patch first, which I assume is needed as it's listed as a dependency. Adding this patch only breaks the tabs, for instance on cataloguing/addbiblio.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9922|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 10074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10074&action=edit Bug 8143 [SIGNED] Upgrade jQuery tabs to current jQueryUI version All appears to work in Chrome and Firefox.. probably worth a second sign off in case I missed anything... there's allot of pages affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch Michael, I'de missed the dependency.. Will re-test/re-base as needed now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10074|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 10084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10084&action=edit Bug 8143 [SIGNED] Upgrade jQuery tabs to current jQueryUI version Now applied after bug7747, still seems to apply cleanly for me? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Michael, what exactly do you mean by "breaks tabs".. for example on cataloguing/addbiblio.pl I'm seeing perfect normal operation.. Wondering if I have something cached somewhere or similar and am there for not seeing the effect of the patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Michael Davis <m.r.davis@cranfield.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Michael Davis <m.r.davis@cranfield.ac.uk> --- (In reply to comment #10)
Michael, what exactly do you mean by "breaks tabs".. for example on cataloguing/addbiblio.pl
I'm seeing perfect normal operation.. Wondering if I have something cached somewhere or similar and am there for not seeing the effect of the patch?
The tabs are not styled as tabs, but appearing as an unstyled ul list. This should be styled by the jquery-ui.css, so either I'm not getting this when I should, or you're getting it when you shouldn't. Could be a caching issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |paul.poulain@biblibre.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: very large patch, but most of it is the new version of jquery tab. Changes in templates are all the same, changing links and tab declaration. I checked some pages and couldn't see anything wrong. No reason to object passed QA, even if, due to the size of the patch, I haven't checked everything ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #11)
(In reply to comment #10)
Michael, what exactly do you mean by "breaks tabs".. for example on cataloguing/addbiblio.pl
I'm seeing perfect normal operation.. Wondering if I have something cached somewhere or similar and am there for not seeing the effect of the patch?
The tabs are not styled as tabs, but appearing as an unstyled ul list. This should be styled by the jquery-ui.css, so either I'm not getting this when I should, or you're getting it when you shouldn't. Could be a caching issue.
OK, checked with Michael, seems it was a FF cache issue, will push -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8229 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10322&action=edit Bug 8143: Follow up - Fixing tabs when editing subfields Fixes broken layout on page for editing subfields of a field in bibliographic MARC frameworks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10322|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 10322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10322 Bug 8143: Follow up - Fixing tabs when editing subfields Missed there is already a patch on bug 8229 :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org