https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42921 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42921 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 201032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201032&action=edit Bug 42921: Add dependency to cpanfile and debian/control Patch from commit fe124f1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42921 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Can you explain the use case a bit more please? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42921 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #2)

Can you explain the use case a bit more please?

Yeah, sure. For bug 34347 I was thinking about using Perl::Critic with a custom policy to analyze Koha Plugins prior to or during install for instance. For bug 30233 I have used it for inspecting user input. Overall, I'd say the utility is for security purposes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42921 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #4)

I feel like it might give a wrong sentiment of "security" because Koha will "check" the quality of the plugin and allow its installations.

We already have unrestricted file upload: bug 34347. https://cheatsheetseries.owasp.org/cheatsheets/File_Upload_Cheat_Sheet.html Personally, I disable web upload of plugins on Koha instances that I manage, so it's not an issue for my paid clients, but I'd like to improve things for the rest of the Koha community. Using Perl::Critic is going to be a lot better than a regex trying to search for powerful/dangerous commands in the Perl. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42921 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30233 -- You are receiving this mail because: You are watching all bug changes.