[Bug 8185] New: Plugin for linking records in MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Priority: P5 - low Change sponsored?: --- Bug ID: 8185 Assignee: gmcharlt@gmail.com Summary: Plugin for linking records in MARC21 Severity: enhancement Classification: Unclassified OS: All Reporter: tajoli@cilea.it Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha In cataloguing/value_builder there is a plugin for linking records. But is only for unimarc (unimarc_field_4XX.pl). We need a plugin also for MARC21 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |tajoli@cilea.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #1 from Zeno Tajoli <tajoli@cilea.it> --- Created attachment 9904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9904&action=edit code of the plugin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Zeno Tajoli <tajoli@cilea.it> --- This is the plugin for linking records in Marc21. It works like the unimarc plugin unimarc_field_4XX. It insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title ) $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on 'any' index. Data are inserted only in the working record. To insert data in the connected record, you need to open the other record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |5p4m@gmx.de --- Comment #3 from Mirko <5p4m@gmx.de> --- - I set up sandbox 8 (http://pro.test8.biblibre.com/) to display 773 9, t, w, x, z in default marc framework - linked the new plugin for subfield 9 - added a second biblio - added data in 001, 020, 022 to second biblio, saved - opened first biblio (sandbox test) - clicked plugin button at 777$9 - searched for "test" - chose biblio2 (marc21 test) All data was added to fields 773 9, t, w, x, z, script is functional. But it is in Italian. Text comes from tt file so it should be translatable strings instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |tajoli@cilea.it --- Comment #4 from Zeno Tajoli <tajoli@cilea.it> --- Correct, there are strings in italian. I update a new version full in english as soon as possible -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #5 from Zeno Tajoli <tajoli@cilea.it> --- Created attachment 11327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11327&action=edit linking plugin marc21 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Version|rel_3_8 |master --- Comment #6 from Zeno Tajoli <tajoli@cilea.it> --- Now the plugin is all in english -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11510&action=edit Bug 8185 Follow-Up: Some more Italian strings changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #8 from Mirko Tietgen <mirko@abunchofthings.net> --- Functionality is still fine, but I found more Italian strings. Sent a followup patch, somebody else needs to signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11327|0 |1 is obsolete| | --- Comment #9 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11529&action=edit This is the plugin for linking records in Marc21. It works like the unimarc plugin unimarc_field_4XX. It insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title ) $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on 'any' index. Data are inserted only in the working record. To insert data in the connected record, you need to open the other record. http://bugs.koha-community.org/show_bug.cgi?id=8185 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11510|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11530&action=edit Bug 8185 Follow-Up: Some more Italian strings changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #11 from Mirko Tietgen <mirko@abunchofthings.net> --- I signed off on Zeno's patch. It works as expected. Since it had some Italian inside I provided a tiny followup. Only the followup needs a signoff by verifying that there is no Italian in the plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Mirko, I tried to apply the follow-up on top of the original signed off patch, but got the following error: Commit Body is: -------------------------- Bug 8185 Follow-Up: Some more Italian strings changed -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 8185 Follow-Up: Some more Italian strings changed /home/jcamins/kohaclone/.git/rebase-apply/patch:14: tab in indent. <h2>Search for</h2> fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8185 Follow-Up: Some more Italian strings changed When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Should there be another follow-up in between the two? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Mirko Tietgen <mirko@abunchofthings.net> --- Jared, thanks for trying. That is odd, seems like I screwed something up when I signed off the first patch. I'll redo the second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11530|0 |1 is obsolete| | --- Comment #14 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11559&action=edit Bug 8185 Change some more strings from Italian to English -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #15 from Mirko Tietgen <mirko@abunchofthings.net> --- I redid the second patch and checked that both patches apply cleanly for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11529|0 |1 is obsolete| | --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11587&action=edit Bug 8185: plugin for linking records in MARC21 This plugin works like the unimarc plugin unimarc_field_4XX. It insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title ) $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on 'any' index. Data are inserted only in the working record. To insert data in the connected record, you need to open the other record. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11559|0 |1 is obsolete| | --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11588&action=edit Bug 8185: Change some more strings from Italian to English Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Two additional corrections -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Looks like this is supposed to be signed off, both patches are signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11588|0 |1 is obsolete| | --- Comment #19 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 11596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11596&action=edit Bug 8185: Change some more strings from Italian to English Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Two additional corrections Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #20 from Mirko Tietgen <mirko@abunchofthings.net> --- (Mit Bezug zu comment 18)
Looks like this is supposed to be signed off, both patches are signed off
Jared signed off my corrections, added two more and asked me to sign them off, so he left it "Needs signoff". I signed off now, we're ready for QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes perlcritic & valid-templates * plugin written like all other plugins passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master (untested, MARC21 specific & no side effect possible) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org