[Bug 40787] New: Plugins buttons misaligned when search box is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Bug ID: 40787 Summary: Plugins buttons misaligned when search box is enabled Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To recreate: 1. Go to Administration > Manage plugins --> Page looks fine, buttons are aligned nicely 2. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 3. Repeat step 1 (hard refresh page) --> Buttons are misaligned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |hammat.wele@inlibro.com CC| |hammat.wele@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 186377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186377&action=edit Bug 40787: Plugins buttons misaligned when search box is enabled The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To test: 1. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 2. Go to Administration > Manage plugins --> Buttons are misaligned 3. Apply the patch 4. Repeat step 2 --> buttons are aligned nicely -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186377|0 |1 is obsolete| | --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 186378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186378&action=edit Bug 40787: Plugins buttons misaligned when search box is enabled The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To test: 1. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 2. Go to Administration > Manage plugins --> Buttons are misaligned 3. Apply the patch 4. Run command « yarn build » 5. Repeat step 2 --> buttons are aligned nicely -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I can't sign off since I work with Hammat, but it works for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186378|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 189486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189486&action=edit Bug 40787: Plugins buttons misaligned when search box is enabled The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To test: 1. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 2. Go to Administration > Manage plugins --> Buttons are misaligned 3. Apply the patch 4. Run command « yarn build » 5. Repeat step 2 --> buttons are aligned nicely Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Step 1 is not required for the latest KTD. 2. Not related to this bug, but if I actually search, for example for 'patrons', I get this error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190 in JSON::from_json at /usr/share/perl5/JSON.pm line 190 187: } 188: } 189: 190: return $json->decode( $_[0] ); 191: } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #5)
2. Not related to this bug, but if I actually search, for example for 'patrons', I get this error:
malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190 in JSON::from_json at /usr/share/perl5/JSON.pm line 190 187: } 188: } 189: 190: return $json->decode( $_[0] ); 191: }
This may be related to Bug 26952 - plugin search term is not correct escaped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #5)
2. Not related to this bug, but if I actually search, for example for 'patrons', I get this error:
malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190 in JSON::from_json at /usr/share/perl5/JSON.pm line 190 187: } 188: } 189: 190: return $json->decode( $_[0] ); 191: }
To avoid this error in current main: 1. Remove this repo from /etc/koha/sites/kohadev/koha-conf.xml: <repo> <name>PTFS Europe</name> <org_name>PTFS-Europe</org_name> <service>github</service> </repo> 2. Change the setting for plugins_restricted to (that is, from 1 to 0): <plugins_restricted>0</plugins_restricted> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189596&action=edit Alternative option: Search form in sidebar Before I knew there was a bug report for this issue I started working on this alternative, putting the form in the sidebar. That feels more consistent to me than putting the search in the toolbar. See also the saved reports page and Acquisitions -> Invoices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #8)
Created attachment 189596 [details] Alternative option: Search form in sidebar
I like it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #9)
(In reply to Owen Leonard from comment #8)
Created attachment 189596 [details] Alternative option: Search form in sidebar
I like it!
I like it as well, but maybe we could still have this as a quick fix - not sure there is a patch yet? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Hammat for the nice test plan, seeing the small annoying fixed makes me happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189486|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193043&action=edit Bug 40787: Plugins buttons misaligned when search box is enabled The buttons in the plugins home page ("Upload plugin" and "View plugins by class") become misaligned when you have the git repository search bar. To test: 1. Add a github/gitlab repository in koha-conf.xml - In ktd shell, open /etc/koha/sites/kohadev/koha-conf.xml - Somewhere under <config> insert the following (or your own) <plugin_repos> <repo> <name>Solutions inLibro</name> <org_name>inLibro</org_name> <service>github</service> </repo> </plugin_repos> - Save the file - restart_all 2. Go to Administration > Manage plugins --> Buttons are misaligned 3. Apply the patch 4. Run command « yarn build » 5. Repeat step 2 --> buttons are aligned nicely Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.04 |26.05.00,25.11.04,25.05.11 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #15 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 --- Comment #16 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: this was pushed for 25.05.11. --LE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40787 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.05.00,25.11.04,25.05.11 |26.05.00,25.11.04,25.05.11, released in| |24.11.16 --- Comment #17 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.16 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org