[Bug 36314] New: koha-email-disable does not disable all emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 Bug ID: 36314 Summary: koha-email-disable does not disable all emails Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz koha-email-enable and koha-email-disable are creating/removing a file (email.enabled) to know if a given instance can send emails. However this is not used from everywhere in Koha, only some debian scripts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- I can't claim to have a full overview of this, but here are some points that come to mind: koha-list has the --email and --noemail switches, to only list instances that have email enabled and disabled respectively. koha-foreach also has the --email and --noemail switches, which build on the functionality in koha-list. Some standard cronjobs that are set up when Koha is installed with the Debian packages use koha-foreach --email, including this: */15 * * * * root koha-foreach --chdir --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl So most messages should be stopped when email is disabled. Including SMS and print (which could come as a surprise, based on the name of the koha-email-{enable,disable} scripts). But there are some functions in Koha that sends email immediately, without relying on process_message_queue.pl. These include, but are not necessarily limited to: - Password reset - Welcome email to newly registered patrons (not sure if that only includes self registered patrons in the OPAC?) Not sure if these respect the email.enabled file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- `koha-email-{enabled|disable}` is only used by `koha-list`. I'm not sure what's the best approach to this. We could have a syspref instead of email.enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we have used this during migrations and such. If we move to a system preference that could also work, but like the email switch it should not only stop sending out the emails, but also prevent their generation in the first place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #3)
I think we have used this during migrations and such.
If we move to a system preference that could also work, but like the email switch it should not only stop sending out the emails, but also prevent their generation in the first place.
I'm not sure that I understand. If you have email disabled, emails will still be generated in Koha. That's something I like because sometimes I want to test email generation without risking sending out emails. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, my impression always was that the cronjob would not run at all with the flag set. Maybe I am wrong and clearly we need to document the intended behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Yeah, when a cronjob is set up with "koha-foreach --email" it will not run if email is disabled. But I can understand David's wish to generate the emails without sending them out. So maybe two sysprefs? - One to not generate messages at all - One to generate messages, bit not send them out This way you could enable generating messages and disable sending them out, to test something, and then delete any unwanted messages before you enable sending messages out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36314 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org