[Bug 6521] New: Editing a patron fails with blank cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Bug #: 6521 Summary: Editing a patron fails with blank cardnumber Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com If it's permissible to have a blank cardnumber, only one person can have one of ''. Editing someone else who has no cardnumber fails with "Cardnumber already in use". Instead, if the cardnumber is empty, it should save as undef. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kyle.m.hall@gmail.com |robin@catalyst.net.nz Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2011-06-21 04:42:46 UTC --- Created attachment 4511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4511 Bug 6521 - allow blank cardnumbers to not trigger "already in use" Now a blank cardnumber will get stored as a null in the database, which is a value that allows duplicates. As such, if cardnumbers aren't mandatory, then you can actually save a user with it being blank. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-25 14:30:10 UTC --- Patch pushed,please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-07-20 17:10:00 UTC --- Problem: if the library is using autoMemberNum, this patch prevents the cardnumber from being generated upon page load of members/memberentry.pl. Seems to be this line that's the offender: @@ -900,6 +900,7 @@ sub fixup_cardnumber ($) { # if ($cardnumber !~ /\S/ && $autonumber_members) { ($autonumber_members) or return $cardnumber; + defined($cardnumber) or return $cardnumber; my $checkdigit = C4::Context->preference('checkdigit'); my $dbh = C4::Context->dbh; if ( $checkdigit and $checkdigit eq 'katipo' ) { If autonumber_members is defined, then cardnumber SHOULDN'T be, because we're auto-generating, and don't yet know what the max value is in the database. That call comes later in the script. This subroutine is only called in two places: member/memberentry.pl and tools/import_borrowers.pl. In both cases, the undefined cardnumber should be passed to the subroutine, and given back as 'undef' if autoMemberNum is off, or the newly calculated cardnumber if ON. Patch forthcoming. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Signed Off --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-07-20 17:26:10 UTC --- Follow up signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-07-20 17:26:35 UTC --- Created attachment 4681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4681 follow up -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-07-20 17:40:04 UTC --- Problem: if the library is using autoMemberNum, this patch prevents the cardnumber from being generated upon page load of members/memberentry.pl. Seems to be this line that's the offender: @@ -900,6 +900,7 @@ sub fixup_cardnumber ($) { # if ($cardnumber !~ /\S/ && $autonumber_members) { ($autonumber_members) or return $cardnumber; + defined($cardnumber) or return $cardnumber; my $checkdigit = C4::Context->preference('checkdigit'); my $dbh = C4::Context->dbh; if ( $checkdigit and $checkdigit eq 'katipo' ) { If autonumber_members is defined, then cardnumber SHOULDN'T be, because we're auto-generating, and don't yet know what the max value is in the database. That call comes later in the script. This subroutine is only called in two places: member/memberentry.pl and tools/import_borrowers.pl. In both cases, the undefined cardnumber should be passed to the subroutine, and given back as 'undef' if autoMemberNum is off, or the newly calculated cardnumber if ON. Patch forthcoming. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gbengaadara@yahoo.com --- Comment #7 from Magnus Enger <magnus@enger.priv.no> 2011-07-26 11:54:15 UTC --- *** Bug 6603 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-31 23:32:27 UTC --- Follow up fix easy to test, and already signed off by QA manager, pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution| |FIXED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-05 21:21:16 UTC --- I can save 2 and more patrons without cardnumber and edit them. Tested on current master. Marking fixed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org