http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I should specify: This patch is for the prog template. A separate bug will address the bootstrap template. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22411|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22418&action=edit Bug 11133 - Markup errors in OPAC place hold form HTML There are markup errors in the OPAC place hold form which prevent it from validating successfully. These errors don't seem to cause any visual problem but can potentially cause problems when debugging template logic. To test, apply the patch and validate the page using your preferred validator (since it's a page which requires login you'll have to upload or paste the source). The page should validate successfully. Test when placing holds on: - a single item - multiple items - items which you cannot place on hold Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22418|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22454&action=edit [PASSED QA] Bug 11133 - Markup errors in OPAC place hold form HTML There are markup errors in the OPAC place hold form which prevent it from validating successfully. These errors don't seem to cause any visual problem but can potentially cause problems when debugging template logic. To test, apply the patch and validate the page using your preferred validator (since it's a page which requires login you'll have to upload or paste the source). The page should validate successfully. Test when placing holds on: - a single item - multiple items - items which you cannot place on hold Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested according to test plan and validated souce code with W3C Validator. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.