[Bug 42984] New: Filtering by date, expiration date, and details on biblio holds table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42984 Bug ID: 42984 Summary: Filtering by date, expiration date, and details on biblio holds table Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Depends on: 23269, 42915 Target Milestone: --- Bug 23269 changed some filtering behavior on the biblio holds table. Bug 42915 restores some of that functionality. Comparing filtering here between 25.05 and main, some differences remain. 25.05 allows one to filter by the values in the Date and Expiration Date columns. This is not possible on main. It's worth noting that this filtering is a little off in 25.05 and seems to be filtering on the un-formatted date value rather than the date as displayed. If a hold is showing a date of "08/02/2026," it will show when filtering to "2026-08-02" but not when filtering to "08/02/2026." Ideally, it would filter based on the display value. 25.05 also allows filtering based on some values in the Details column, while main does not. Though 25.05 also functions imperfectly here. When I have a mix of "Next Available" and "Non priority" holds, I don't get anything when I filter to "next," but I do get my non priority hold when filtering to "non." For item-specific holds, I can filter by the item barcode. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 [Bug 23269] Long hold queues are slowing the service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 [Bug 42915] Filtering Holds table by patron name or pickup library is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42984 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42984 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I notice even after bug 42915 and bug 42357 that there is a Javascript error so probably plays a factor... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42984 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #1)
I notice even after bug 42915 and bug 42357 that there is a Javascript error so probably plays a factor...
And kids this is why we don't play with global variables... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42984 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915#c37 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42984 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I'll be looking into that Javascript error at the very least tomorrow and probably this more broadly... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42984 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 204499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204499&action=edit Bug 42984: Fix filtering hold table by date and expiration This patch adds type: "date" and searchable: "true" to the column definitions for Date and Expiration in the holds table. To test: 1. Create some holds on a bib and add different expiration dates 2. Try searching by an expiration date using the displayed date 3. See 'No matching results found' 4. Apply patch and restart all 5. Try step 2 again using the displayed date and iso format 2026-09-19 6. Note: searching by iso supports partial dates like 09-19 but searching by the displayed date only supports exact matches like '09/19/2026' This is because iso dates are in the database and matches with { like: "%" + value + "%" }; Since bug 37542 dayjs uses strict parsing, so only exact matches are supported for displayed dates. Assisted-by: Sonnet 5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42984 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- The patch for searching by date is pretty trivial, but there's one catch. Bug 37542 is the reason why partial matching on the display date does not work with this patch. Searching by the Details column is a whole nother situation. The column's data attribute is "" not a real attribute name, and the rendered content with js combining a few different fields. It's kind of like the display date issue but even more gnarly because it doesn't have a related database column at all. The content in the column is only client side and the search happens server side. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org