[Bug 18688] New: Warnings about UTF-8 charset when creating a new language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bug ID: 18688 Summary: Warnings about UTF-8 charset when creating a new language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Creatinng a new language produces several warnings. To reproduce: cd /koha/misc/translator$ perl translate create aa-AA Or, if env vars are not set (change path as appropriate): sudo env KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone perl translate create aa-AA Result:
Warning: Can't determine original templates' charset, defaulting to UTF-8 Warning: Charset Out defaulting to UTF-8 Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345.
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 [Bug 18629] Translatability: Fix problems with web installer 17.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18629 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 [Bug 18629] Translatability: Fix problems with web installer 17.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 96122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96122&action=edit Bug 18688: Warnings about UTF-8 charset when creating a new language This patch removes some warnings when creating new languages, those related with uft8 and two not related. Tipical messages are:
Warning: Can't determine original templates' charset, defaulting to UTF-8 Warning: Charset Out defaulting to UTF-8 ... Removing empty file /../xx-YY-marc-NORMARC.po I UTF-8 O UTF-8 at /../kohaclone/misc/translator/tmpl_process3.pl line 365. Use of uninitialized value $pref_name in concatenation (.) or string at /.../misc/translator/LangInstaller.pm line 197. Created /../misc/translator/po/xx-YY-messages.po.
First four are 'normal' messages The fifth one correspond to an unquoted preference string The sixth one is a normal output message from msgint command We will hide them unless verbose '-v' option is selected, and fix the error. To test: 1) Go to misc/translator 2) Create new language files $ perl translate create xx-YY 3) Check warnings and messages 4) Apply the patch 5) Remove created files, and create them again Ther must be no messages 6) Repeat 5) with verbose option '-v', check old messages 7) BONUS: without the patch update a language, for example de-DE: $ perl translate update de-DE Note (git status) a new file, po/de-DE-messages.po~ This is a backup file from msgmerge command With the patch this backup is removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96122|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96305&action=edit Bug 18688: Warnings about UTF-8 charset when creating a new language This patch removes some warnings when creating new languages, those related with uft8 and two not related. Tipical messages are:
Warning: Can't determine original templates' charset, defaulting to UTF-8 Warning: Charset Out defaulting to UTF-8 ... Removing empty file /../xx-YY-marc-NORMARC.po I UTF-8 O UTF-8 at /../kohaclone/misc/translator/tmpl_process3.pl line 365. Use of uninitialized value $pref_name in concatenation (.) or string at /.../misc/translator/LangInstaller.pm line 197. Created /../misc/translator/po/xx-YY-messages.po.
First four are 'normal' messages The fifth one correspond to an unquoted preference string The sixth one is a normal output message from msgint command We will hide them unless verbose '-v' option is selected, and fix the error. To test: 1) Go to misc/translator 2) Create new language files $ perl translate create xx-YY 3) Check warnings and messages 4) Apply the patch 5) Remove created files, and create them again Ther must be no messages 6) Repeat 5) with verbose option '-v', check old messages 7) BONUS: without the patch update a language, for example de-DE: $ perl translate update de-DE Note (git status) a new file, po/de-DE-messages.po~ This is a backup file from msgmerge command With the patch this backup is removed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96305|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96565&action=edit Bug 18688: Warnings about UTF-8 charset when creating a new language This patch removes some warnings when creating new languages, those related with uft8 and two not related. Tipical messages are:
Warning: Can't determine original templates' charset, defaulting to UTF-8 Warning: Charset Out defaulting to UTF-8 ... Removing empty file /../xx-YY-marc-NORMARC.po I UTF-8 O UTF-8 at /../kohaclone/misc/translator/tmpl_process3.pl line 365. Use of uninitialized value $pref_name in concatenation (.) or string at /.../misc/translator/LangInstaller.pm line 197. Created /../misc/translator/po/xx-YY-messages.po.
First four are 'normal' messages The fifth one correspond to an unquoted preference string The sixth one is a normal output message from msgint command We will hide them unless verbose '-v' option is selected, and fix the error. To test: 1) Go to misc/translator 2) Create new language files $ perl translate create xx-YY 3) Check warnings and messages 4) Apply the patch 5) Remove created files, and create them again Ther must be no messages 6) Repeat 5) with verbose option '-v', check old messages 7) BONUS: without the patch update a language, for example de-DE: $ perl translate update de-DE Note (git status) a new file, po/de-DE-messages.po~ This is a backup file from msgmerge command With the patch this backup is removed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24262 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02 |20.05.00, 19.11.02, released in| |18.11.13 CC| |hayleymapley@catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #7 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02, |20.05.00, 19.11.02, released in|18.11.13 |19.05.07, 18.11.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org