[Bug 41060] New: Add a value_builder to check if ISSN is valid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Bug ID: 41060 Summary: Add a value_builder to check if ISSN is valid Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl same as Bug29980 but for ISSN. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29980 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 188200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188200&action=edit Bug 41060: Add a cataloguing plugin to check ISSN Test plan: - without patch login to Koha - edit a biblio and put a wrong ISSN in 022a (011a for unimarc). - leave the input field (looses focus), no warning - apply patch and do "reset_all" to make a full re-install. - edit the biblio again and put an invalid ISSN in 022a (011a for unimarc). - when you leave the input field you should have a warning saying "invalid ISSN". - the input field should turn yellow - you can still save the biblio with a wrong issn, it is just a warning. - if you apply the patch on an existing install, you must manually link the value builder to your existing frameworks to get it working. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188200|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188418&action=edit Bug 41060: Add a cataloguing plugin to check ISSN Test plan: - without patch login to Koha - edit a biblio and put a wrong ISSN in 022a (011a for unimarc). - leave the input field (looses focus), no warning - apply patch and do "reset_all" to make a full re-install. - edit the biblio again and put an invalid ISSN in 022a (011a for unimarc). - when you leave the input field you should have a warning saying "invalid ISSN". - the input field should turn yellow - you can still save the biblio with a wrong issn, it is just a warning. - if you apply the patch on an existing install, you must manually link the value builder to your existing frameworks to get it working. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a new release notes| |cataloging plugin (value | |builder) for validating | |ISSNs. If you enter an | |invalid ISSN, a browser | |pop-up window warns that | |the ISSN is invalid, but | |you can ignore this (the | |field is highlighted in | |yellow) and still save the | |record. | | | |For new installations, the | |validate_issn.pl plugin is | |added to the bibliographic | |frameworks by default for | |022$a (MARC21) or 011$a | |(UNIMARC). | | | |For existing installations, | |update your frameworks | |manually. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Some observations: If I leave 022 empty, there is a warn about invalid ISSN. Thats weird. Please fix. If I enter a valid ISSN like 1234-5679, it is ok. If I enter 1234-5679A, it is ok too and that is confusing. If I enter 1234-5679X, it is wrong. Coming from Business::ISSN. So out of scope ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 190929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190929&action=edit Bug 41060: (QA follow-up) improve ISSN format detection Two tests have been added: - not only the checksum of the ISSN is checked but also the format. - if the ISSN is left empty, the plugin won't give a warning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190929|0 |1 is obsolete| | --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 190930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190930&action=edit Bug 41060: (QA follow-up) improve ISSN format detection Two tests have been added: - not only the checksum of the ISSN is checked but also the format. - if the ISSN is left empty, the plugin won't give a warning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Marcel de Rooy from comment #3)
Some observations:
If I leave 022 empty, there is a warn about invalid ISSN. Thats weird. Please fix.
If I enter a valid ISSN like 1234-5679, it is ok. If I enter 1234-5679A, it is ok too and that is confusing. If I enter 1234-5679X, it is wrong. Coming from Business::ISSN. So out of scope ?
Hi Marcel, The latest patch should fix all the point you mentionned, I've added some controls and a regexp to check the format :) qa scripts are ha Happy new year! Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188418|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 190943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190943&action=edit Bug 41060: Add a cataloguing plugin to check ISSN Test plan: - without patch login to Koha - edit a biblio and put a wrong ISSN in 022a (011a for unimarc). - leave the input field (looses focus), no warning - apply patch and do "reset_all" to make a full re-install. - edit the biblio again and put an invalid ISSN in 022a (011a for unimarc). - when you leave the input field you should have a warning saying "invalid ISSN". - the input field should turn yellow - you can still save the biblio with a wrong issn, it is just a warning. - if you apply the patch on an existing install, you must manually link the value builder to your existing frameworks to get it working. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190930|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 190944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190944&action=edit Bug 41060: (QA follow-up) improve ISSN format detection Two tests have been added: - not only the checksum of the ISSN is checked but also the format. - if the ISSN is left empty, the plugin won't give a warning. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #9 from David Nind <david@davidnind.com> --- Testing notes (using KTD) - MARC21 installation: 1. Examples of valid and invalid ISSNs: - Valid: 0317-8471, 1050-124X, 1234-5679 - Invalid: 1234-5679X (too long), 1234-567 (too short), 1234-567A (only X is allowed) 2. Edit the SER framework to add validate_issn.pl to 22$a. 3. Edit a record with an ISSN tag (I used Chapman, biblionumber = 44) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #10 from David Nind <david@davidnind.com> --- Just adding this link about ISSNs and their format: https://www.issn.org/understanding-the-issn/what-is-an-issn/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190943|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 191557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191557&action=edit Bug 41060: Add a cataloguing plugin to check ISSN Test plan: - without patch login to Koha - edit a biblio and put a wrong ISSN in 022a (011a for unimarc). - leave the input field (looses focus), no warning - apply patch and do "reset_all" to make a full re-install. - edit the biblio again and put an invalid ISSN in 022a (011a for unimarc). - when you leave the input field you should have a warning saying "invalid ISSN". - the input field should turn yellow - you can still save the biblio with a wrong issn, it is just a warning. - if you apply the patch on an existing install, you must manually link the value builder to your existing frameworks to get it working. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190944|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 191558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191558&action=edit Bug 41060: (QA follow-up) improve ISSN format detection Two tests have been added: - not only the checksum of the ISSN is checked but also the format. - if the ISSN is left empty, the plugin won't give a warning. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 191559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191559&action=edit Bug 41060: (QA follow-up) Check in change, trigger once in Blur If we already checked and nothing changes, no need to check again. Set focus to field if we warn. For consistency copied these changes to validate_isbn. Test plan: Try various valid and invalid ISSNs. Tab through the field repeatedly; you should only have a warning once, if the ISSN is invalid (yellow colored). Save a bad ISSN into a record. Open it again and tab through ISSN; you should be warned. Repeat similarly for ISBN field. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 191560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191560&action=edit Bug 41060: (QA follow-up) Consistent return for empty string An empty ISBN should not warn just like an empty ISSN. Test plan: Verify that clearing ISBN or ISSN does not warn anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Added follow-up for some minor things. Still seeing that adding additional text outside [0-9X] is fine for ISBN, but is not for ISSN. This inconsistency comes from the regex that we use in ISSN (and not in ISBN). No big thing. Note that catalogers may be used to more text after an ISBN? But when using an additional X the ISBN will be invalid.. Which is a bit weird again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41060 Laure <laure.roy@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Laure Roy contact| | Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1238 Resolution|--- |FIXED CC| |laure.roy@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org