http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13321 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33869&action=edit Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33871&action=edit Bug 13323: [DO NOT PUSH] Tax rate can change on receiving - DBIC changes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com --- Comment #5 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- I tested this patch on BibLibre's sandbox17. Here is what I did. I created 4 new vendors to test 4 different set ups : Set up 1 = List prices INCLUDE TAX + Invoice prices INCLUDE TAX Set up 2 = List prices EXCLUDE TAX + Invoice prices EXCLUDE TAX Set up 3 = List prices INCLUDE TAX + Invoice prices EXCLUDE TAX Set up 4 = List prices EXCLUDE TAX + Invoice prices INCLUDE TAX For each vendor, default tax rate is 5%. Then, for each vendor : * I add 1 basket with 1 item. Vendor price is 10 euros. Default tax rate is 5%. * I check the prices and tax caculation on the basket page. Everything is well calculated (prices tax included or excluded) * I close the basket and go to the receive page * I receive the item and change the tax rate to 10%. * I check the prices and tax calculation on the receive page. For the set ups 1 and 2, I have what I expected. Not for the set ups 3 and 4. Set up 1 (List prices INCLUDE TAX + Invoice prices INCLUDE TAX): Ordering : Vendor price (tax incl) = 10 euros <---- what I entered Vendor price (tax excl) = 9.52 euros Tax amount (5%) = 0.48 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10 euros Receiving : Vendor price (tax incl) = 10 euros (= value in actual cost) Vendor price (tax excl) = 9.09 euros Tax amount (10%) = 0.91 euros Total (tax excl) = 9.09 euros Total (tax incl) = 10 euros Set up 2 (List prices EXCLUDE TAX + Invoice prices EXCLUDE TAX): Ordering : Vendor price (tax incl) = 10.5 euros Vendor price (tax excl) = 10 euros <---- what I entered Tax amount (5%) = 0.5 euros Total (tax excl) = 10 euros Total (tax incl) = 10.5 euros Receiving : Vendor price (tax incl) = 11 euros Vendor price (tax excl) = 10 euros (= value in actual cost) Tax amount (10%) = 1 euros Total (tax excl) = 10 euros Total (tax incl) = 11 euros Set up 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX): Ordering : Vendor price (tax incl) = 10 euros <---- what I entered Vendor price (tax excl) = 9.52 euros Tax amount (5%) = 0.48 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10 euros Receiving (what we have now): Vendor price (tax incl) = 10.47 euros Vendor price (tax excl) = 9.52 euros (= value in actual cost) Tax amount (10%) = 0.95 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10.47 euros Receiving (what I expected): Vendor price (tax incl) = 10 euros Vendor price (tax excl) = 9.09 euros (= value in actual cost) Tax amount (10%) = 0.91 euros Total (tax excl) = 9.09 euros Total (tax incl) = 10 euros Since I entered the price tax included and then changed the tax rate, I expected the actual cost, which is here the price tax excluded, to be recalculated. But here, the value in actual cost is the price tax excluded calculated on the price tax included with a 5% tax (but I changed it to 10%...) Set up 4 (List prices EXCLUDE TAX + Invoice prices INCLUDE TAX): Ordering : Vendor price (tax incl) = 10.5 euros Vendor price (tax excl) = 10 euros <---- what I entered Tax amount (5%) = 0.5 euros Total (tax excl) = 10 euros Total (tax incl) = 10.5 euros Receiving (what we have) : Vendor price (tax incl) = 10.50 euros (= value in actual cost) Vendor price (tax excl) = 9.55 euros Tax amount (10%) = 0.95 euros Total (tax excl) = 9.55 euros Total (tax incl) = 10.50 euros Receiving (what I expected) : Vendor price (tax incl) = 11 euros (= value in actual cost) Vendor price (tax excl) = 10 euros Tax amount (10%) = 1 euros Total (tax excl) = 10 euros Total (tax incl) = 11 euros Same logic than before. I expected the value in actual cost to be recalculated. In a few words, I expect the reference value on which calculation should be based to be the one I entered when I placed the order. So, if I change the tax rate during the receiving process, I expect the actual cost to be recalculated. Here, the actual cost calculation is always based on the tax rate we have when placing the order. To me, it's not logical. Jonathan, could you ask librarians in charge of acquisition what they think of this. I'll trust their judgment. If the logic in place is good. You can signed off these patches. If not, tell me when it's ready and I'll test it again. ;^) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- For the setup 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX), I would have the same analysis as Laurence : the change of tax between order and receipt should not change prices tax excl. that are the basis. So this patch introduce the right calculation. For the setup4 (List prices EXCLUDE TAX + Invoice prices INCLUDE TAX), It would be better that the price tax incl. was recalculated in the order receive page. But for me, it's not the most important. What really matters is that the calculation is right after the receipt was recorded. There's often a change of price between the order and the receipt and the calculation have to take into account the entered price. Sonia Bouis -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- In the end, about the set up 3, Laurence, Sonia, I agree with both of you. About the set up 4, I'll keep what we have now because it shares the same logic thabn the set up 3. I tested the patches on Biblibre's sandbox17. Jonathan, could you sign them off on my behalf? Thanks! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Francois Charbonnier from comment #8)

Jonathan, could you sign them off on my behalf?

Added on the remote branch :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13726 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10253 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14541 -- You are receiving this mail because: You are watching all bug changes.