[Bug 16578] New: Wide character warning in opac-export.pl when utf8 chosen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Bug ID: 16578 Summary: Wide character warning in opac-export.pl when utf8 chosen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51743&action=edit Bug 16578: Fix wide character errors in opac-export.pl This simple patch fixes wide character warning raised by opac-export.pl when 'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen for downloading records. To test: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... - Choose Save record > MARC (Unicode/UTF-8, Standard) => FAILE opac-export.pl: Wide character in print... - Apply the patch - Choose Save record > MARC (Unicode/UTF-8) => SUCCESS: No warnings raised. - Choose Save record > MARC (Unicode/UTF-8, Standard) => SUCCESS: No warnings raised. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51743|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51774&action=edit Bug 16578: Fix wide character errors in opac-export.pl This simple patch fixes wide character warning raised by opac-export.pl when 'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen for downloading records. To test: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... - Choose Save record > MARC (Unicode/UTF-8, Standard) => FAILE opac-export.pl: Wide character in print... - Apply the patch - Choose Save record > MARC (Unicode/UTF-8) => SUCCESS: No warnings raised. - Choose Save record > MARC (Unicode/UTF-8, Standard) => SUCCESS: No warnings raised. - Sign off :-D Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51798&action=edit Bug 16578: Same fix for the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51798|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51888&action=edit [SIGNED-OFF] Bug 16578: Same fix for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as first patch No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51774|0 |1 is obsolete| | Attachment #51888|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52233&action=edit Bug 16578: Fix wide character errors in opac-export.pl This simple patch fixes wide character warning raised by opac-export.pl when 'MARC (Unicode/UTF-8)' and 'MARC (Unicode/UTF-8, Standard)' formats are chosen for downloading records. To test: - Have records indexed - Open your OPAC logs: $ tail -f /var/log/koha/kohadev/opac-error.log - Open the detail page in the opac for a record - Choose Save record > MARC (Unicode/UTF-8) => FAIL: opac-export.pl: Wide character in print at /home/vagrant/kohaclone/opac/opac-export.pl line 116., referer: http://localh... - Choose Save record > MARC (Unicode/UTF-8, Standard) => FAILE opac-export.pl: Wide character in print... - Apply the patch - Choose Save record > MARC (Unicode/UTF-8) => SUCCESS: No warnings raised. - Choose Save record > MARC (Unicode/UTF-8, Standard) => SUCCESS: No warnings raised. - Sign off :-D Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52234&action=edit Bug 16578: Same fix for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as first patch No errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16578 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org