[Bug 25877] New: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Bug ID: 25877 Summary: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106287&action=edit Bug 25877: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. Test Plan: 1) Log in to Koha 2) Set your logged in branch to not be a pickup location 3) Attempt to place a hold 4) Note the error message 5) Apply this patch 6) Restart plack 7) Reload the page 8) Note the error is gone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- I should note, this bug does not present in master. I think it was fixed by bug 22284 though I have not proven it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106287|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 106292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106292&action=edit Bug 25877: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. Test Plan: 1) Log in to Koha 2) Set your logged in branch to not be a pickup location 3) Attempt to place a hold 4) Note the error message 5) Apply this patch 6) Restart plack 7) Reload the page 8) Note the error is gone! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106292|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 106310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106310&action=edit Bug 25877: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. Test Plan: 1) Log in to Koha 2) Set your logged in branch to not be a pickup location 3) Attempt to place a hold 4) Note the error message 5) Apply this patch 6) Restart plack 7) Reload the page 8) Note the error is gone! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error |[19.11] Error |libraryNotPickupLocation |libraryNotPickupLocation |when placing a hold if |when placing a hold if |logged in branchcode is not |logged in branchcode is not |a pickup location |a pickup location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have done the following: - I have changed Centerville to be 'no pickup location' in the library configuration - My staff patron has home library Centerville and that was also my logged in library - When I try to place a hold, Centerville is not in the pickup location list, but there is also no error. I can place holds with other pickup locations without an error. What am I missing? I was testing on latest 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Just tested on 19.11.x, the problem still exists: https://monosnap.com/file/gbped1dKxSpMy7LU9Lz10lZHjXHrmw (In reply to Katrin Fischer from comment #5)
I have done the following: - I have changed Centerville to be 'no pickup location' in the library configuration - My staff patron has home library Centerville and that was also my logged in library - When I try to place a hold, Centerville is not in the pickup location list, but there is also no error. I can place holds with other pickup locations without an error.
What am I missing? I was testing on latest 19.11.x
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I didn't see that red message - any other pref or so I might need to toggle? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |alex.arnaud@biblibre.com |y.org | CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- libraryNotPickupLocation red message disapears and we only have pickup location libraries in the list => Ok Just a specific case: If i set all my libraries as "no pickup location", i have no error message, an empty pickup location list and i can place a hold. I agree that it's a very specific case and not likely to happen. But can you technically accept a hold without pickup location ? What's your opinion on this ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Alex Arnaud from comment #8)
libraryNotPickupLocation red message disapears and we only have pickup location libraries in the list => Ok
Just a specific case: If i set all my libraries as "no pickup location", i have no error message, an empty pickup location list and i can place a hold.
I agree that it's a very specific case and not likely to happen. But can you technically accept a hold without pickup location ?
What's your opinion on this ?
I think that would make a good bug report on its own. If no libraries are set as pickup locations, it makes sense to me to hide the holds tab altogether, or at the very least, disallow holds to be placed so long as there are no pickup locations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Kyle M Hall from comment #9)
I think that would make a good bug report on its own. If no libraries are set as pickup locations, it makes sense to me to hide the holds tab altogether, or at the very least, disallow holds to be placed so long as there are no pickup locations.
Why not just keep the "libraryNotPickupLocation" red message in this case ? IMO that could be done more quickly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Alex Arnaud from comment #10)
(In reply to Kyle M Hall from comment #9)
I think that would make a good bug report on its own. If no libraries are set as pickup locations, it makes sense to me to hide the holds tab altogether, or at the very least, disallow holds to be placed so long as there are no pickup locations.
Why not just keep the "libraryNotPickupLocation" red message in this case ? IMO that could be done more quickly.
Because in that scenario, there are no libraries in the pulldown, so stating "this library is not a pickup location" doesn't really make sense. There is no library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106310|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109291&action=edit Bug 25877: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. Test Plan: 1) Log in to Koha 2) Set your logged in branch to not be a pickup location 3) Attempt to place a hold 4) Note the error message 5) Apply this patch 6) Restart plack 7) Reload the page 8) Note the error is gone! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Retested with success on a clean 19.11.x branch. I agree that the behaviour for all libraries set to be no pickup location could be handled separately so we can have this as a fix for the stable branches first. I filed: Bug 26319 - Disable holds when all libraries are set to be no pickup-location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sending to 19.11 queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org