[Bug 33828] New: ExportCircHistory description is misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Bug ID: 33828 Summary: ExportCircHistory description is misleading Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The description for ExportCircHistory is currently [Show/Don't show] the export patron checkout history options. However, the option to export is only available for the patron's current checkouts, not their checkout history. Either we add ExportCircHistory in members/readingrec.pl (circulation history) or we rename/change the description to say that this pref is used to export current checkouts. Current behaviour: 1. Enable ExportCircHistory 2. Go to a patron's account who has checkouts, or check out some items to a patron --> Note that in the checkouts table at the bottom of the page, there is an 'Export' column and at the bottom of the table, there are export options 3. Go to the patron's Details tab --> Note that in the checkouts table at the bottom of the page, there is an 'Export' column and at the bottom of the table, there are export options 4. Go to the patron's Circulation history tab --> No additional export options (other than the datatables thing) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- ExportRemoveFields also mentions the "patron checkout history", but like ExportCircHistory it has nothing to do with the checkout history (both prefs are linked). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 152578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152578&action=edit Bug 33828: ExportCircHistory description is misleading This patch removes the mention of checkout history from the ExportCircHistory system preference description, as this system preference only allows to export current checkouts, not checkout history. This patch also modifies the description of the ExportRemoveFields system preference to also remove mention of checkout history. To test: 0. Apply patch 1. Go to Administration > System preferences > Circulation 2. Read the description for ExportCircHistory, make sure it makes sense, and that spelling and syntax are correct 3. Read the description for ExportRemoveFields, make sure it makes sense, and that spelling and syntax are correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm not convinced this is the way to go, but I corrected the descriptions for ExportCircHistory and ExportRemoveFields to remove mention of checkout history. I think it would be better to expand the functionality to checkout history, but it is outside my abilities. At least this way it removes a bit of confusion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152578|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 154221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154221&action=edit Bug 33828: ExportCircHistory description is misleading This patch removes the mention of checkout history from the ExportCircHistory system preference description, as this system preference only allows to export current checkouts, not checkout history. This patch also modifies the description of the ExportRemoveFields system preference to also remove mention of checkout history. To test: 0. Apply patch 1. Go to Administration > System preferences > Circulation 2. Read the description for ExportCircHistory, make sure it makes sense, and that spelling and syntax are correct 3. Read the description for ExportRemoveFields, make sure it makes sense, and that spelling and syntax are correct Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154221|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155793&action=edit Bug 33828: ExportCircHistory description is misleading This patch removes the mention of checkout history from the ExportCircHistory system preference description, as this system preference only allows to export current checkouts, not checkout history. This patch also modifies the description of the ExportRemoveFields system preference to also remove mention of checkout history. To test: 0. Apply patch 1. Go to Administration > System preferences > Circulation 2. Read the description for ExportCircHistory, make sure it makes sense, and that spelling and syntax are correct 3. Read the description for ExportRemoveFields, make sure it makes sense, and that spelling and syntax are correct Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial QA.. Passed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/774 Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40623 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41314 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org