[Bug 19291] New: Make breadbrumbs for OPAC search history consistent with other patron account pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Bug ID: 19291 Summary: Make breadbrumbs for OPAC search history consistent with other patron account pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org If the user is logged in the search history can be accessed from within the patron account. In this case the breadcrumbs are not consistent with the other patron account pages in that the name of the logged-in user is missing. Patch might take into account that there is an anomymous search history too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make breadbrumbs for OPAC |Make breadcrumbs for OPAC |search history consistent |search history consistent |with other patron account |with other patron account |pages |pages Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77309&action=edit Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77309|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 77312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77312&action=edit Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Other files have the patron.title displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)
Other files have the patron.title displayed.
Well, not all... Should not we fix everything at once on this bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do you mean all other pages or just this one? If the patron title is not on all pages, maybe this could be a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- With this patch we are fixing half of the inconsistency, so yes we could fix that on a separate bug report, if you prefer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77312|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77363&action=edit Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21137 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6)
With this patch we are fixing half of the inconsistency, so yes we could fix that on a separate bug report, if you prefer.
See bug 21137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 [Bug 21137] Remplace BORROWER_INFO and USER_INFO with logged_in_user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77363|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77405&action=edit Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21137 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org