[Bug 41735] New: Remove double comma in source code for OPAC self-registration page (QA error)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 Bug ID: 41735 Summary: Remove double comma in source code for OPAC self-registration page (QA error) Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org The opac/opac-memberentry.pl has a double comma in the source code. This generates a tidy error when the qa script is run. Line 280: branchcode => $patron->branchcode,, I'm not sure if this has any effect on how the page works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 192180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192180&action=edit Bug 41735: Tidy OPAC self-registration page - fix qa warning opac/opac-memberentry.pl has a double comma in the source code. This generates a tidy error when the qa script is run. Test plan: 1. Review the patch and note that the double comma is removed. 2. Run the qa script - there should be no warnings or errors: qa Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37143 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 [Bug 37143] Patron registration allows for saving required fields with a single space instead of information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37143 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 [Bug 37143] Patron registration allows for saving required fields with a single space instead of information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove double comma in |Remove double comma in |source code for OPAC |source code for OPAC |self-registration page (QA |self-registration page |error) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 192193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192193&action=edit Bug 41735: Tidy OPAC self-registration page opac/opac-memberentry.pl has a double comma in the source code. Test plan: 1. Tidy the file: perl misc/devel/tidy.pl opac/opac-memberentry.pl 2. Generate a diff: git diff 3. Note the double comma. 4. Reset everything: git checkout opac/opac-memberentry.pl 5. Apply the patch. 6. Repeat steps 1 and 2 - no tidy changes made. 7. Run the qa script - there should be no warnings or errors: qa Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 --- Comment #3 from David Nind <david@davidnind.com> --- Updated the commit message with a "better" test plan. Running qa by itself doesn't identify the double comma. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- *** This bug has been marked as a duplicate of bug 41076 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org