[Bug 17010] New: Canceling a hold that has been waiting too long from Holds Awaiting Pickup no longer alerts librarian about next hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Bug ID: 17010 Summary: Canceling a hold that has been waiting too long from Holds Awaiting Pickup no longer alerts librarian about next hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, the librarian would be alerted with the message "This item is on hold for pick-up at your library" and directed to check it in to fill the next hold. This no longer happens. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 53840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53840&action=edit Bug 17010 - Canceling a hold that has been waiting too long from Holds Awaiting Pickup no longer alerts librarian about next hold In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, the librarian would be alerted with the message "This item is on hold for pick-up at your library" and directed to check it in to fill the next hold. This no longer happens. Test Plan: 1) Apply this patch 2) Find a hold that has been waiting too long 3) Cancel that hold via waitingreserves.pl 4) Note you get the message "This item is on hold for pick-up at your library" 5) Confirm the ok button redirects you to the correct tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Canceling a hold that has |Canceling a hold awaiting |been waiting too long from |pickup no longer alerts |Holds Awaiting Pickup no |librarian about next hold |longer alerts librarian | |about next hold | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53840|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54241&action=edit [SIGNED-OFF] Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, the librarian would be alerted with the message "This item is on hold for pick-up at your library" and directed to check it in to fill the next hold. This no longer happens. Test Plan: 1) Apply this patch 2) Find a hold that has been waiting too long 3) Cancel that hold via waitingreserves.pl 4) Note you get the message "This item is on hold for pick-up at your library" 5) Confirm the ok button redirects you to the correct tab Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54242&action=edit Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold This patch makes a minor change to the markup to make the button in the confirmation dialog conform to the appearance of similar buttons. To test, follow the original test plan for this bug and verify that the "OK" button in the dialog looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54242|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 55387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55387&action=edit y# Attachment to Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold This patch makes a minor change to the markup to make the button in the confirmation dialog conform to the appearance of similar buttons. To test, follow the original test plan for this bug and verify that the "OK" button in the dialog looks correct. Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54241|0 |1 is obsolete| | Attachment #55387|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55459&action=edit [PASSED QA] Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it, the librarian would be alerted with the message "This item is on hold for pick-up at your library" and directed to check it in to fill the next hold. This no longer happens. Test Plan: 1) Apply this patch 2) Find a hold that has been waiting too long 3) Cancel that hold via waitingreserves.pl 4) Note you get the message "This item is on hold for pick-up at your library" 5) Confirm the ok button redirects you to the correct tab Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55460&action=edit [PASSED QA] Bug 17010 [Follow-up] Canceling a hold awaiting pickup no longer alerts librarian about next hold This patch makes a minor change to the markup to make the button in the confirmation dialog conform to the appearance of similar buttons. To test, follow the original test plan for this bug and verify that the "OK" button in the dialog looks correct. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks for the followup Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17150 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17335 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17337 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 58052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58052&action=edit Bug 17010 FOLLOWUP fix typo waitingreserves.p#[% tab %] should be waitingreserves.pl#[% tab %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #58052|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Comment on attachment 58052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58052 Bug 17010 FOLLOWUP fix typo Moved followup to bug 17749 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17010 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19685 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org