[Bug 22321] New: Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Bug ID: 22321 Summary: Make it possible to edit illrequests.borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no Target Milestone: --- Sometimes an ILL request is connected to the wrong borrower, and it would be nice to be able to connect it to the right one. In Swedish ILL the cardnumber of the patron connected with an ILL request is entered into the central Libris system and then propagated to Koha through the Libris API. This can lead to errors, and we have created a dummy "ILL patron" to catch these. It would then be good to be able to connect the ILL to the right patron in Koha. We could implement this in the Libris backend, but I think it is relevant for other backends too, and should be implemented in the ILL module itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24338 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- If the ILL request is connected to a bibliographic record and that record has a reservation connected to the original patron, that reservation also needs to be moved to the new patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 130544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130544&action=edit Bug 22321: Add unit tests To test: 1. prove t/db_dependent/Illrequests.t 2. Observe test failure 1..3 ok 1 - before change, original borrowernumber found not ok 2 - after change, changed borrowernumber found in holds # Failed test 'after change, changed borrowernumber found in holds' # at t/db_dependent/Illrequests.t line 167. # got: '3786' # expected: '3787' ok 3 - after change, changed borrowernumber found in illrequests # Looks like you failed 1 test of 3. not ok 4 - store borrowernumber change also updates holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #3 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 130545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130545&action=edit Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes To test: 1. prove t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #4 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 130546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130546&action=edit Bug 22321: Allow managing the borrowernumber tied to ILL request Sometimes an ILL request is connected to the wrong borrower, and it would be nice to be able to connect it to the right one. In Swedish ILL the cardnumber of the patron connected with an ILL request is entered into the central Libris system and then propagated to Koha through the Libris API. This can lead to errors, and we have created a dummy "ILL patron" to catch these. It would then be good to be able to connect the ILL to the right patron in Koha. This commit makes it possible to edit illrequests.borrowernumber. To test: 1. Apply patch 2. Create two patrons, A and B 3. Create a new ILL request for patron A 4. Add a hold for patron A where biblionumber is the biblio tied to this ILL request 5. Go to cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161 6. Observe Patron ID is editable 7. Change borrowernumber to patron B's borrowernumber 8. Click save 9. Observe ILL request is now for patron B 10. Go to patron B's details at cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber 11. At the bottom section of the page, click 1 Hold(s) 12. Observe the hold you placed at step 4 has transferred to patron b -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- After applying these patches I get this when I try to create a new illrequest: Can't call method "borrowernumber" on an undefined value at /home/me/kohaclone/Koha/Illrequest.pm line 1643. 1637 my @holds; 1638 if( defined $updated_columns{'borrowernumber'} and 1639 Koha::Patrons->find( $updated_columns{'borrowernumber'} ) ) 1640 { 1641 # borrowernumber has changed 1642 my $old_illreq = $self->get_from_storage; 1643 @holds = Koha::Holds->search( { 1644 borrowernumber => $old_illreq->borrowernumber, 1645 biblionumber => $self->biblio_id, 1646 } )->as_list; 1647 } Not sure what the problem is, but could it be that this works for existing requests, but for new ones there just isn't an $old_illreq to get the borrowernumber from? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #6 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 131012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131012&action=edit Bug 22321: Unit test for new()->borrowernumber()->store() -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #7 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Magnus Enger from comment #5)
After applying these patches I get this when I try to create a new illrequest:
Can't call method "borrowernumber" on an undefined value at /home/me/kohaclone/Koha/Illrequest.pm line 1643.
1637 my @holds; 1638 if( defined $updated_columns{'borrowernumber'} and 1639 Koha::Patrons->find( $updated_columns{'borrowernumber'} ) ) 1640 { 1641 # borrowernumber has changed 1642 my $old_illreq = $self->get_from_storage; 1643 @holds = Koha::Holds->search( { 1644 borrowernumber => $old_illreq->borrowernumber, 1645 biblionumber => $self->biblio_id, 1646 } )->as_list; 1647 }
Not sure what the problem is, but could it be that this works for existing requests, but for new ones there just isn't an $old_illreq to get the borrowernumber from?
Good catch. I've added an unit test to cover this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #8 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 131013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131013&action=edit Bug 22321: Fix store() crash when modifying borrowernumber of a new ILL request To test: 1. prove t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130544|0 |1 is obsolete| | --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- Created attachment 131055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131055&action=edit Bug 22321: Add unit tests To test: 1. prove t/db_dependent/Illrequests.t 2. Observe test failure 1..3 ok 1 - before change, original borrowernumber found not ok 2 - after change, changed borrowernumber found in holds # Failed test 'after change, changed borrowernumber found in holds' # at t/db_dependent/Illrequests.t line 167. # got: '3786' # expected: '3787' ok 3 - after change, changed borrowernumber found in illrequests # Looks like you failed 1 test of 3. not ok 4 - store borrowernumber change also updates holds Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130545|0 |1 is obsolete| | --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- Created attachment 131056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131056&action=edit Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130546|0 |1 is obsolete| | --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- Created attachment 131057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131057&action=edit Bug 22321: Allow managing the borrowernumber tied to ILL request Sometimes an ILL request is connected to the wrong borrower, and it would be nice to be able to connect it to the right one. In Swedish ILL the cardnumber of the patron connected with an ILL request is entered into the central Libris system and then propagated to Koha through the Libris API. This can lead to errors, and we have created a dummy "ILL patron" to catch these. It would then be good to be able to connect the ILL to the right patron in Koha. This commit makes it possible to edit illrequests.borrowernumber. To test: 1. Apply patch 2. Create two patrons, A and B 3. Create a new ILL request for patron A 4. Add a hold for patron A where biblionumber is the biblio tied to this ILL request 5. Go to cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161 6. Observe Patron ID is editable 7. Change borrowernumber to patron B's borrowernumber 8. Click save 9. Observe ILL request is now for patron B 10. Go to patron B's details at cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber 11. At the bottom section of the page, click 1 Hold(s) 12. Observe the hold you placed at step 4 has transferred to patron b Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131012|0 |1 is obsolete| | --- Comment #12 from Magnus Enger <magnus@libriotech.no> --- Created attachment 131058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131058&action=edit Bug 22321: Unit test for new()->borrowernumber()->store() Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131013|0 |1 is obsolete| | --- Comment #13 from Magnus Enger <magnus@libriotech.no> --- Created attachment 131059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131059&action=edit Bug 22321: Fix store() crash when modifying borrowernumber of a new ILL request To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger <magnus@libriotech.no> Tried to change the borrowernumber connected to an ILL request and checked that the associated hold was updated to the new patron as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #14 from Magnus Enger <magnus@libriotech.no> --- I have signed off on these patches, as they work for me. However, I am involved in commissioning these patches, so I do not update the BZ status from NSO to SO. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd like to sign-off, but have issues with the tests here before and after applying the patch. This is without the patches: kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Illrequests.t t/db_dependent/Illrequests.t .. 9/13 # Failed test 'We get expected error on notforloan of item' # at t/db_dependent/Illrequests.t line 1150. # Structures begin differing at: # $got->{confirm} = HASH(0x564c474ded60) # $expected->{confirm} = Does not exist # Failed test at t/db_dependent/Illrequests.t line 1173. # got: 'form' # expected: 'done_check_out' # Failed test at t/db_dependent/Illrequests.t line 1175. # got: '0' # expected: '1' # Failed test at t/db_dependent/Illrequests.t line 1176. # got: 'YPI9JroljKCZerYRd4NATNNudqRk7gIs0eisCksKqghavsp' # expected: 'CHK' # Looks like you failed 4 tests of 17. t/db_dependent/Illrequests.t .. 10/13 # Failed test 'Checking out' # at t/db_dependent/Illrequests.t line 1179. t/db_dependent/Illrequests.t .. 13/13 # Looks like you failed 1 test of 13. t/db_dependent/Illrequests.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/13 subtests Test Summary Report ------------------- t/db_dependent/Illrequests.t (Wstat: 256 Tests: 13 Failed: 1) Failed test: 10 Non-zero exit status: 1 Files=1, Tests=13, 10 wallclock secs ( 0.06 usr 0.00 sys + 8.58 cusr 1.42 csys = 10.06 CPU) Result: FAIL Any idea about this? Do they pass for you, Magnus? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31324 [Bug 31324] Use patron search when editing the borrowernumber of an ILL request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tests are passing now, but will provide a follow-up to fix the number of planned tests. The UX is not good, we should use a proper patron search here instead of requiring to enter the borrowernumber. I've filed this as a separate issue: Bug 31324 - Use patron search when editing the borrowernumber of an ILL request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131055|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138873&action=edit Bug 22321: Add unit tests To test: 1. prove t/db_dependent/Illrequests.t 2. Observe test failure 1..3 ok 1 - before change, original borrowernumber found not ok 2 - after change, changed borrowernumber found in holds # Failed test 'after change, changed borrowernumber found in holds' # at t/db_dependent/Illrequests.t line 167. # got: '3786' # expected: '3787' ok 3 - after change, changed borrowernumber found in illrequests # Looks like you failed 1 test of 3. not ok 4 - store borrowernumber change also updates holds Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131056|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138874&action=edit Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131057|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138875&action=edit Bug 22321: Allow managing the borrowernumber tied to ILL request Sometimes an ILL request is connected to the wrong borrower, and it would be nice to be able to connect it to the right one. In Swedish ILL the cardnumber of the patron connected with an ILL request is entered into the central Libris system and then propagated to Koha through the Libris API. This can lead to errors, and we have created a dummy "ILL patron" to catch these. It would then be good to be able to connect the ILL to the right patron in Koha. This commit makes it possible to edit illrequests.borrowernumber. To test: 1. Apply patch 2. Create two patrons, A and B 3. Create a new ILL request for patron A 4. Add a hold for patron A where biblionumber is the biblio tied to this ILL request 5. Go to cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161 6. Observe Patron ID is editable 7. Change borrowernumber to patron B's borrowernumber 8. Click save 9. Observe ILL request is now for patron B 10. Go to patron B's details at cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber 11. At the bottom section of the page, click 1 Hold(s) 12. Observe the hold you placed at step 4 has transferred to patron b Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131058|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138876&action=edit Bug 22321: Unit test for new()->borrowernumber()->store() Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131059|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138877&action=edit Bug 22321: Fix store() crash when modifying borrowernumber of a new ILL request To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger <magnus@libriotech.no> Tried to change the borrowernumber connected to an ILL request and checked that the associated hold was updated to the new patron as well. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138878&action=edit Bug 22321: (follow-up) Fix number of planned tests in Illrequests.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138873|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141342&action=edit Bug 22321: Add unit tests To test: 1. prove t/db_dependent/Illrequests.t 2. Observe test failure 1..3 ok 1 - before change, original borrowernumber found not ok 2 - after change, changed borrowernumber found in holds # Failed test 'after change, changed borrowernumber found in holds' # at t/db_dependent/Illrequests.t line 167. # got: '3786' # expected: '3787' ok 3 - after change, changed borrowernumber found in illrequests # Looks like you failed 1 test of 3. not ok 4 - store borrowernumber change also updates holds Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138874|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141343&action=edit Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138875|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141344&action=edit Bug 22321: Allow managing the borrowernumber tied to ILL request Sometimes an ILL request is connected to the wrong borrower, and it would be nice to be able to connect it to the right one. In Swedish ILL the cardnumber of the patron connected with an ILL request is entered into the central Libris system and then propagated to Koha through the Libris API. This can lead to errors, and we have created a dummy "ILL patron" to catch these. It would then be good to be able to connect the ILL to the right patron in Koha. This commit makes it possible to edit illrequests.borrowernumber. To test: 1. Apply patch 2. Create two patrons, A and B 3. Create a new ILL request for patron A 4. Add a hold for patron A where biblionumber is the biblio tied to this ILL request 5. Go to cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161 6. Observe Patron ID is editable 7. Change borrowernumber to patron B's borrowernumber 8. Click save 9. Observe ILL request is now for patron B 10. Go to patron B's details at cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber 11. At the bottom section of the page, click 1 Hold(s) 12. Observe the hold you placed at step 4 has transferred to patron b Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138876|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141345&action=edit Bug 22321: Unit test for new()->borrowernumber()->store() Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138877|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141346&action=edit Bug 22321: Fix store() crash when modifying borrowernumber of a new ILL request To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger <magnus@libriotech.no> Tried to change the borrowernumber connected to an ILL request and checked that the associated hold was updated to the new patron as well. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138878|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141347&action=edit Bug 22321: (follow-up) Fix number of planned tests in Illrequests.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact| |martin.renvoize@ptfs-europe | |.com --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another nice improvement, all working as advertised. No QA failures or regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #31 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org