http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-16 16:19:39 UTC --- Created attachment 7175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7175 Bug 7447 allow to specify a date in overdue_notice.pl This patch add a new parameter to overdue_notices.pl, that is a date. If you add --date=YYYY-MM-DD when running overdue_notices, it will generate overdues as if you were on date provided that's usefull if you want to relaunch an overdue calculation that has failed, of after changing your circ rules -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Ian Walls <koha.sekjal@gmail.com> 2012-02-07 15:17:48 UTC --- This patch doesn't do any kind of format-checking on the 'date' param, and then loads the variable directly into the SQL. This could cause the query to fail (at best), return completely different values than intended, or destroy entire tables (at very worst). The date variable should be parameterized for the sth->execute(), and should be rigourously checked for proper date formatting. If the incoming value is not a correct date, either warn and use NOW(), or abort the script. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7175|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9995&action=edit [SIGNED-OFF] Bug 7447 allow to specify a date in overdue_notice.pl This patch add a new parameter to overdue_notices.pl, that is a date. If you add --date=YYYY-MM-DD when running overdue_notices, it will generate overdues as if you were on date provided that's usefull if you want to relaunch an overdue calculation that has failed, of after changing your circ rules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- $dbh->quote takes care of the cleanliness, so my original objection is withdrawn. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch introduces a bug, see Bug 8607 -- You are receiving this mail because: You are watching all bug changes.