[Bug 18990] New: Overdue Notices are not sending through SMS correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Bug ID: 18990 Summary: Overdue Notices are not sending through SMS correctly Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: nick@bywatersolutions.com Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org For SMS messages to be sent, the patron has to have a phone number to receive text messages and their carrier. When an enhanced message sends(advance notices, holds, checkin, checkouts) it takes the phone number and adds the appropriate carrier information to it. For the Over Notices, the SMS number is not getting attached to the carrier information, the email information is being used instead. Thus the patron is receiving an SMS overdue notice via their email address instead of through a text message. See below- an advanced notice of Item due sent via SMS uses the phone number, however, the overdue Notice uses the email address: select message_id, to_address, subject, message_transport_type as mtt from message_queue where message_transport_type='sms' and date(time_queued) = CURRENT_DATE limit 10; +------------+------------------------------------------------------+----------------------------+-----+ | message_id | to_address | subject | mtt | +------------+------------------------------------------------------+----------------------------+-----+ | 549913 | cabs@gmail.com@vtext.com@vtext.com@vtext.com | Overdue Notice | sms | | 551808 | llie.re@btx.gov@txt.att.net | Overdue Notice | sms | | 551811 | nbur5@tx.rr.com@tmomail.net | Overdue Notice | sms | | 551814 | jbeel@gmail.com@vtext.com | Overdue Notice | sms | | 551871 | 8172284361@tmomail.net | Advance Notice of Item Due | sms | | 551873 | 8172284361@tmomail.net | Advance Notice of Item Due | sms | | 551875 | 8172284361@tmomail.net | Advance Notice of Item Due | sms | | 551901 | 817-879-8111@txt.att.net | Advance Notice of Item Due | sms | | 551904 | 817-879-8111@txt.att.net | Advance Notice of Item Due | sms | | 551906 | 817-879-8111@txt.att.net | Advance Notice of Item Due | sms | +------------+------------------------------------------------------+----------------------------+-----+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65312&action=edit Bug 18990 - Overdue Notices are not sending through SMS correctly Bug 18478 fixed sms via email problems under the assumption that to_address was either smsalertnumber or blank. It seems overdues set the to_address to email. This patch changes the code to enforce that an sms sent with emial driver will use the smsalertnumebr and provider defined for the borrower, regardless of what is set in the queue To test: 1 - Define a messaging prefs for a patron to recieve hold notices via SMS 2 - Ensure you have defined an SMS message for an overdue letter 3 - Set an SMS alert number for patron 4 - Set the SMS::Send driver to 'Email' 5 - Checkout an item as overdue to trigger notice above 6 - Run overdue_notices.pl 6 - Check the db and note the address is email 7 - run process_message_queue.pl 8 - Check db - address is email followed by service provider 9 - Apply patch 10 - repeat 11 - Message to_address should be populated with smsalertnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 [Bug 18478] Some notices sent via SMS gateway fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65312|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 66308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66308&action=edit [SIGNED-OFF] Bug 18990 - Overdue Notices are not sending through SMS correctly Bug 18478 fixed sms via email problems under the assumption that to_address was either smsalertnumber or blank. It seems overdues set the to_address to email. This patch changes the code to enforce that an sms sent with emial driver will use the smsalertnumebr and provider defined for the borrower, regardless of what is set in the queue To test: 1 - Define a messaging prefs for a patron to recieve hold notices via SMS 2 - Ensure you have defined an SMS message for an overdue letter 3 - Set an SMS alert number for patron 4 - Set the SMS::Send driver to 'Email' 5 - Checkout an item as overdue to trigger notice above 6 - Run overdue_notices.pl 6 - Check the db and note the address is email 7 - run process_message_queue.pl 8 - Check db - address is email followed by service provider 9 - Apply patch 10 - repeat 11 - Message to_address should be populated with smsalertnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66308|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67686&action=edit Bug 18990 - Overdue Notices are not sending through SMS correctly Bug 18478 fixed sms via email problems under the assumption that to_address was either smsalertnumber or blank. It seems overdues set the to_address to email. This patch changes the code to enforce that an sms sent with emial driver will use the smsalertnumebr and provider defined for the borrower, regardless of what is set in the queue To test: 1 - Define a messaging prefs for a patron to recieve hold notices via SMS 2 - Ensure you have defined an SMS message for an overdue letter 3 - Set an SMS alert number for patron 4 - Set the SMS::Send driver to 'Email' 5 - Checkout an item as overdue to trigger notice above 6 - Run overdue_notices.pl 6 - Check the db and note the address is email 7 - run process_message_queue.pl 8 - Check db - address is email followed by service provider 9 - Apply patch 10 - repeat 11 - Message to_address should be populated with smsalertnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67686|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69080&action=edit Bug 18990 - Overdue Notices are not sending through SMS correctly Bug 18478 fixed sms via email problems under the assumption that to_address was either smsalertnumber or blank. It seems overdues set the to_address to email. This patch changes the code to enforce that an sms sent with emial driver will use the smsalertnumebr and provider defined for the borrower, regardless of what is set in the queue To test: 1 - Define a messaging prefs for a patron to recieve hold notices via SMS 2 - Ensure you have defined an SMS message for an overdue letter 3 - Set an SMS alert number for patron 4 - Set the SMS::Send driver to 'Email' 5 - Checkout an item as overdue to trigger notice above 6 - Run overdue_notices.pl 6 - Check the db and note the address is email 7 - run process_message_queue.pl 8 - Check db - address is email followed by service provider 9 - Apply patch 10 - repeat 11 - Message to_address should be populated with smsalertnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.07 Just had to change $patron->smsalertnumber into $member->{'smsalertnumber'} -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org