[Bug 20828] New: Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Bug ID: 20828 Summary: Step 4 of moremember is used for Housebound and additional attributes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Enable the Housebound module and Additional attributes, hit cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=51&step=4 You see: https://screenshots.firefox.com/kckI5solTzmkbPv4/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5670 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not a bug? commit 20c2ea7d3a6e24dd13cf3e6dd47108984852607d Bug 5670: [Followup] Add 'step 4' edit button. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 [Bug 5670] Housebound Readers Module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Architecture, internals, |Templates |and plumbing | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is the bug that there are 2 Edit links for both that lead to the same page? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #2)
Is the bug that there are 2 Edit links for both that lead to the same page?
step 4 is used for both housebound module and additional attributes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085 [Bug 21085] Can't edit patrons with housebound module active -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77139&action=edit Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Bug 20828 depends on bug 21085, which changed state. Bug 21085 Summary: Can't edit patrons with housebound module active https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Cab Vinton <bibliwho@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 77466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77466&action=edit Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. Signed-off-by: Cab Vinton <bibliwho@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77466|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77483&action=edit Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. Signed-off-by: Cab Vinton <bibliwho@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03. We don't appear to actually have any direct dependency on bug 21085 here so it works well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 [Bug 21209] When trying to edit housebound roles, the edit button goes to patron attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 21085 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21080 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- Hi, I think this patchset caused bug 21080 - classes of attributes go outside of the attributes area when HouseBound is disabled. Attributes that have no class are fine. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org