[Bug 36998] New: 'Issue refund' modal on registers.pl can mistakenly display amount from previously clicked on transaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Bug ID: 36998 Summary: 'Issue refund' modal on registers.pl can mistakenly display amount from previously clicked on transaction Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Point of Sale Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: martin.renvoize@ptfs-europe.com CC: martin.renvoize@ptfs-europe.com In the POS module, the 'Issue refund' modal on registers.pl mistakenly carries forward the amount paid to subsequent modals. Steps to reproduce: -Have the Point of Sale module enabled, a cash register defined and multiple debit types defined -Make multiple sales -View the transaction history for your sales on register.pl -Click on the 'Issue refund' button for one of the sales -Notice that the 'amount paid' displays the amount of the sale -Realize that you selected the wrong transaction for the refund -Find the actual transaction you want to refund and click on the 'Issue refund' button -Notice that the amount listed in the 'amount paid' area is the amount from the first refund you attempted to make, not the amount for the transaction now being handled In the attached screenshots one shows a payment of 3.80. That turned out to be the wrong transaction. Staff then located the correct transaction to be refunded. The amount shows 3.80 (carried over from the previous transaction that was clicked on) but the amount of the original payment was actually 7.40. Not only is the amount of 3.80 incorrect but it is especially confusing since it looks as if you would be refunding more than the original payment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 --- Comment #1 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 167293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167293&action=edit Amount paid in 'Issue refund modal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 167294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167294&action=edit Incorrect amount paid in 'Issue refund modal carried over from previous transaction -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 169589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169589&action=edit Bug 36998: Correctly update the 'Amount paid' displayed on the issue refund modal To test: 1) Enable the 'EnablePointOfSale' sys pref (also requires the 'UseCashRegisters' pref) 2) In the POS module, configure a cash register and also configure some items for purchase with different costs 3) Make multiple sales 4) View the transactions table by clicking the 'Cash summary for ...' tab and then clicking on your cash register's name. 5) Click on the 'Issue refund' button for one of the sales, this should have the correct 'Amount paid' 6) Close the modal and click issue refund on your other item. 7) Note the 'Amount paid' is incorrect and lists the value from the previous item 8) Apply patch 9) Now when clicking issue refund, it displays the correct 'Amount paid' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169589|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 169596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169596&action=edit Bug 36998: Correctly update the 'Amount paid' displayed on the issue refund modal To test: 1) Enable the 'EnablePointOfSale' sys pref (also requires the 'UseCashRegisters' pref) 2) In the POS module, configure a cash register and also configure some items for purchase with different costs 3) Make multiple sales 4) View the transactions table by clicking the 'Cash summary for ...' tab and then clicking on your cash register's name. 5) Click on the 'Issue refund' button for one of the sales, this should have the correct 'Amount paid' 6) Close the modal and click issue refund on your other item. 7) Note the 'Amount paid' is incorrect and lists the value from the previous item 8) Apply patch 9) Now when clicking issue refund, it displays the correct 'Amount paid' Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169596|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169740&action=edit Bug 36998: Correctly update the 'Amount paid' displayed on the issue refund modal To test: 1) Enable the 'EnablePointOfSale' sys pref (also requires the 'UseCashRegisters' pref) 2) In the POS module, configure a cash register and also configure some items for purchase with different costs 3) Make multiple sales 4) View the transactions table by clicking the 'Cash summary for ...' tab and then clicking on your cash register's name. 5) Click on the 'Issue refund' button for one of the sales, this should have the correct 'Amount paid' 6) Close the modal and click issue refund on your other item. 7) Note the 'Amount paid' is incorrect and lists the value from the previous item 8) Apply patch 9) Now when clicking issue refund, it displays the correct 'Amount paid' Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'Issue refund' modal on |'Issue refund' modal on |registers.pl can mistakenly |cash register transactions |display amount from |page can mistakenly display |previously clicked on |amount from previously |transaction |clicked on transaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.04 |24.11.00,24.05.04,23.11.09 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36998 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org