[Bug 27682] New: Add a floating table header for Search engine configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Bug ID: 27682 Summary: Add a floating table header for Search engine configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr The table header in Elastic search should be a floating bar, as the table could be veeeeery long. It's sometimes hard to remember what is the order of the different Yes/No dropdown menus and it can be the source of confusion or bad settings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117088&action=edit Bug 27682: Add a floating table header for Search engine configuration This patch adds DataTables options to the tables on the search engine configuration pages. The table on the "Search fields" tab will be sortable, all tables will be searchable, and all tables will have floating headers. To test you should have the SearchEngine preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - Test the tables under each tab, "Search fields," "Bibliographic records," and "Authorities," the table has a search filter and the header row "sticks" to the top of the browser window as you scroll down. - The "Search fields" table should be sortable, but the other two should not--they have drag-and-drop row reordering. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117088|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 117104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117104&action=edit Bug 27682: Add a floating table header for Search engine configuration This patch adds DataTables options to the tables on the search engine configuration pages. The table on the "Search fields" tab will be sortable, all tables will be searchable, and all tables will have floating headers. To test you should have the SearchEngine preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - Test the tables under each tab, "Search fields," "Bibliographic records," and "Authorities," the table has a search filter and the header row "sticks" to the top of the browser window as you scroll down. - The "Search fields" table should be sortable, but the other two should not--they have drag-and-drop row reordering. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |search filter and a | |floating table header (that | |"sticks" to the top of the | |browser window as you | |scroll down) to the search | |engine | |configuration pages | |(Administration > Catalog > | |Search engine configuration | |(Elasticsearch)). | | | |The | |"Search fields" table is | |sortable, but the | |"Bibliographic records" and | |"Authorities" tables are | |not as they have | |drag-and-drop row | |reordering. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a |This enhancement adds a release notes|search filter and a |search filter and a |floating table header (that |floating table header (that |"sticks" to the top of the |"sticks" to the top of the |browser window as you |browser window as you |scroll down) to the search |scroll down) to the search |engine |engine configuration pages |configuration pages |(Administration > Catalog > |(Administration > Catalog > |Search engine configuration |Search engine configuration |(Elasticsearch)). |(Elasticsearch)). | | |The |The |"Search fields" table is |"Search fields" table is |sortable, but the |sortable, but the |"Bibliographic records" and |"Bibliographic records" and |"Authorities" tables are |"Authorities" tables are |not as they have |not as they have |drag-and-drop row |drag-and-drop row |reordering. |reordering. | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117104|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117422&action=edit Bug 27682: Add a floating table header for Search engine configuration This patch adds DataTables options to the tables on the search engine configuration pages. The table on the "Search fields" tab will be sortable, all tables will be searchable, and all tables will have floating headers. To test you should have the SearchEngine preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - Test the tables under each tab, "Search fields," "Bibliographic records," and "Authorities," the table has a search filter and the header row "sticks" to the top of the browser window as you scroll down. - The "Search fields" table should be sortable, but the other two should not--they have drag-and-drop row reordering. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. There is a weird behaviour, when you hit land on the page the floating header is wider than the thead. However if you go to the bibliographic or authorities tab and come back, it's ok. 2. tableInit( "", "search_fields"); In tableInit we should test if oldtabid is passed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117759&action=edit Bug 27682: (follow-up) Make sure table is drawn with correct width The DataTables plugin calculates the width of the fixed header based on the initial width of the corresponding table. Since these tables are inside jQueryUI tabs, the width changes when the tabs are initialized and jQueryUI adds its classes to the table's container. This patch "manually" adds the relevant classes to the markup so that the table's container is drawn with the right padding from the start. Also fixed: Don't try to destroy "oldTableId" if the tableInit function didn't pass an oldtabid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Super enhancement. I'd like to see it in 20.11.x. I've applied patches with a small conflict but table header is not floating :( Can you create patches for 20.11.x please ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27403 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Fridolin Somers from comment #7)
Can you create patches for 20.11.x please ?
The feature depends on Bug 27403. I've updated the dependencies to reflect it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 [Bug 27403] Enable fixedHeader for Datatables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #8)
(In reply to Fridolin Somers from comment #7)
Can you create patches for 20.11.x please ?
The feature depends on Bug 27403. I've updated the dependencies to reflect it.
Ok super thanks. In the end this is too much a change for stable branch. One can always cherry-pick the patches ;) Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 20588 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org