https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108394&action=edit Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Audio alerts. - Click the "Delete selected alerts" button without checking any checkboxes. You should see an error: "Check the box next to the alert you want to delete." - Check the checkbox for an existing sound and click "Delete selected alerts." You should get a confirmation message, "Are you sure you want to delete the selected audio alerts?" - Click "New alert." - Without filling any details, click the "Play sound" button. You should see an error message, "Please select or enter a sound." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:

cd misc/translator perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js for translation, e.g.: msgid "Are you sure you want to delete the selected audio alerts?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:

perl translate install fr-FR

- Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108394|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 110817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110817&action=edit Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Audio alerts. - Click the "Delete selected alerts" button without checking any checkboxes. You should see an error: "Check the box next to the alert you want to delete." - Check the checkbox for an existing sound and click "Delete selected alerts." You should get a confirmation message, "Are you sure you want to delete the selected audio alerts?" - Click "New alert." - Without filling any details, click the "Play sound" button. You should see an error message, "Please select or enter a sound." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:

cd misc/translator perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js for translation, e.g.: msgid "Are you sure you want to delete the selected audio alerts?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:

perl translate install fr-FR

- Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110817|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110822&action=edit Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Audio alerts. - Click the "Delete selected alerts" button without checking any checkboxes. You should see an error: "Check the box next to the alert you want to delete." - Check the checkbox for an existing sound and click "Delete selected alerts." You should get a confirmation message, "Are you sure you want to delete the selected audio alerts?" - Click "New alert." - Without filling any details, click the "Play sound" button. You should see an error message, "Please select or enter a sound." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:

cd misc/translator perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js for translation, e.g.: msgid "Are you sure you want to delete the selected audio alerts?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:

perl translate install fr-FR

- Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.