[Bug 15136] New: Display item's homebranch in patron's fines list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Bug ID: 15136 Summary: Display item's homebranch in patron's fines list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: contact@kanellov.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Displaying the item's homebranch for item in "Description of charges" would be useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #1 from Vassilis Kanellopoulos <contact@kanellov.com> --- I've submitted a pull request for this enhancement. https://github.com/Koha-Community/Koha/pull/10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Vassilis Kanellopoulos <contact@kanellov.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |contact@kanellov.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Vassilis, thx for your contribution! Can you please attach a patch file to this bug? The Koha community is not using github pull requests in its development workflow. Some additional information can be found on the wiki: http://wiki.koha-community.org/wiki/Development_workflow http://wiki.koha-community.org/wiki/SubmitingAPatch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #3 from Vassilis Kanellopoulos <contact@kanellov.com> --- Created attachment 44630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44630&action=edit add homebranch of borrowed items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Vassilis Kanellopoulos <contact@kanellov.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |contact@kanellov.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Vassilis! Once the patch file is attached, you can switch the bug status to "Needs Signoff". This way it shows up on the queues for things to be tested. One tiny thing about your patch: + <th>Item Homebranch</th> We only have the first term in capitals, also please check the term we use in the normal item view or in the checkouts list for comparison. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Vassilis Kanellopoulos <contact@kanellov.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44630|0 |1 is obsolete| | --- Comment #5 from Vassilis Kanellopoulos <contact@kanellov.com> --- Created attachment 44644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44644&action=edit add homebranch of borrowed items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Vassilis Kanellopoulos <contact@kanellov.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Vassilis Kanellopoulos <contact@kanellov.com> --- Thanks Kartin. I've changed table heading. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 44671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44671&action=edit Add homebranch of borrowed items to patron accounts tab http://bugs.koha-community.org/show_bug.cgi?id=15136 Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Hi Vassilis, I signed off, works as expected. I added a test plan to the commit message, you should always include one with the patch submission to make testing easier (and so you can be sure that you and the tester agree on what the results should be :-) ) -Nick -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #9 from Vassilis Kanellopoulos <contact@kanellov.com> --- (In reply to Nick Clemens from comment #8)
Hi Vassilis,
I signed off, works as expected. I added a test plan to the commit message, you should always include one with the patch submission to make testing easier (and so you can be sure that you and the tester agree on what the results should be :-) )
-Nick
Hi Nick, Thanks for the advice. It's my first contribution to Koha and I'm still learning the process. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Attachment #44644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44671|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44681&action=edit Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44682&action=edit Bug 15136: Use TT plugin to display the branch's name Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org