[Bug 16621] New: Translatability: Issues in opac-user.tt (sentence splitting)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Bug ID: 16621 Summary: Translatability: Issues in opac-user.tt (sentence splitting) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Fix translation issues by sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 103: <li id="renewal_blocked_fines"><strong>Please note: </strong> Since you have <a href="/cgi-bin/koha/opac-account.pl">[% IF renewal_blocked_fines != "0.00" %] more than <span id="renewal_blocked_fines_amount">[% renewal_blocked_fines %]</span> in [% END %] fines</a>, you cannot renew your books online. Please pay your fines if you wish to renew your books.</li> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 52216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52216&action=edit Bug 16621: Translatability: Issues in opac-user.tt (sentence splitting) This patch fixes issues due to sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Note: This is a string patch. It does not add or change functionallity. To test: - Examine code and verify that the text changes remove sentence splitting and that the changes make sense. - Log in to OPAC and verify that messages look correct - with blocked /debarred user (with and without comment and date) - with user who has to much fines (needs syspref OpacRenewalAllowed and syspref OPACFineNoRenewals) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information (with and without syspref OPACPatronDetails set to Allow) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Text to go in the| |Fix translatability issues release notes| |due to sentence splitting | |in | |koha-tmpl/opac-tmpl/bootstr | |ap/en/modules/opac-user.tt Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52216|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 53252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53252&action=edit Bug 16621: Translatability: Issues in opac-user.tt (sentence splitting) This patch fixes issues due to sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Note: This is a string patch. It does not add or change functionallity. To test: - Examine code and verify that the text changes remove sentence splitting and that the changes make sense. - Log in to OPAC and verify that messages look correct - with blocked /debarred user (with and without comment and date) - with user who has to much fines (needs syspref OpacRenewalAllowed and syspref OPACFineNoRenewals) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information (with and without syspref OPACPatronDetails set to Allow) Note: Amended to make patch apply 2016-07-10 mv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53252|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53269&action=edit [SIGNED-OFF] Bug 16621: Translatability: Issues in opac-user.tt (sentence splitting) This patch fixes issues due to sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Note: This is a string patch. It does not add or change functionallity. To test: - Examine code and verify that the text changes remove sentence splitting and that the changes make sense. - Log in to OPAC and verify that messages look correct - with blocked /debarred user (with and without comment and date) - with user who has to much fines (needs syspref OpacRenewalAllowed and syspref OPACFineNoRenewals) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information (with and without syspref OPACPatronDetails set to Allow) Note: Amended to make patch apply 2016-07-10 mv Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16898 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think we could leave out the "Reason:" here: + <li id="renewal_blocked_fines"><strong>Please note: </strong>You cannot renew your books online. Reason: [% IF ( renewal_blocked_fines ) > 0 %... But not a blocker :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53269|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53280&action=edit [PASSED QA] Bug 16621: Translatability: Issues in opac-user.tt (sentence splitting) This patch fixes issues due to sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Note: This is a string patch. It does not add or change functionallity. To test: - Examine code and verify that the text changes remove sentence splitting and that the changes make sense. - Log in to OPAC and verify that messages look correct - with blocked /debarred user (with and without comment and date) - with user who has to much fines (needs syspref OpacRenewalAllowed and syspref OPACFineNoRenewals) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information (with and without syspref OPACPatronDetails set to Allow) Note: Amended to make patch apply 2016-07-10 mv Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12509 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19849 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org