[Bug 12291] New: remove acronym for CAS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Bug ID: 12291 Summary: remove acronym for CAS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org The HTML tag acronym is obsolete for HTML5 and also complicates translation. In sources : <p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account, It generates : msgid "If you have a " msgid "Central Authentication Service" msgid "account, %s please " This is difficult to translate correctly because strings are splitted. For example in French, the translation is actually : msgid "Si vous avez un " msgid "Central Authentication Service (Service d'Identification Centralisé)" msgid "compte, %s s'il vous plait " It generates : <p>Si vous avez un <acronym title="Central Authentication Service (Service d'Identification Centralisé)">CAS</acronym> compte, %s s'il vous plait. It should be : <p>Si vous avez un compte <acronym title="Central Authentication Service (Service d'Identification Centralisé)">CAS</acronym>, %s s'il vous plait. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 28347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28347&action=edit Bug 12291 - remove acronym for CAS (bootstrap) The HTML tag acronym is obsolete for HTML5 and also complicates translation. In sources : <p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account, It generates : msgid "If you have a " msgid "Central Authentication Service" msgid "account, %s please " This is difficult to translate correctly because strings are splitted. For example in French, the translation is actually : msgid "Si vous avez un " msgid "Central Authentication Service (Service d'Identification Centralisé)" msgid "compte, %s s'il vous plait " It generates : <p>Si vous avez un <acronym title="Central Authentication Service (Service d'Identification Centralisé)">CAS</acronym> compte, %s s'il vous plait. It should be : <p>Si vous avez un compte <acronym title="Central Authentication Service (Service d'Identification Centralisé)">CAS</acronym>, %s s'il vous plait. This patch removes the acronym tag and moves the title attribute to the h4 tag. Test plan : - Enable OPAC bootstrap theme - Enable casAuthentication - Go to login page /cgi-bin/koha/opac-user.pl => Without patch you see "If you have a CAS account", CAS is a acronym tag. => With patch you see "If you have a CAS account" without acronym tag and "CAS login" has a title "Login via Central Authentication Service" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 --- Comment #2 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 28348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28348&action=edit Bug 12291 - remove acronym for CAS (prog) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 pierre.lorgue@ens-cachan.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |pierre.lorgue@ens-cachan.fr --- Comment #3 from pierre.lorgue@ens-cachan.fr --- The patch doesn't work completely we correctly apply bootstrap theme and cas authentication goto the opac login page The acronym is still there; The h4 title is correctly modified but the display is not effective, the acronym is still there <!--CONTENT--> <!-- login prompt time--> <h3> … </h3> <h4 title="Login via Central Authentication Service"> Identification par CAS </h4> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to pierre.lorgue from comment #3)
The patch doesn't work completely Thanks for testing.
I see your text is in french. You must test in "en" language, meaning without translation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Attachment #28348|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 28348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28348 Bug 12291 - remove acronym for CAS (prog) Since the prog theme has been deleted, this patch is not needed anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Fridolin, this should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28347|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36064&action=edit Bug 12291: Replace acronym with tag at the OPAC On the OPAC authentification page, the acronym tag is used, but deprecated. It should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym Test plan: Enable the CAS authentification and verify the tags have correctly been replaced. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|remove acronym for CAS |Replace the acronym HTML | |tag with abbr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 --- Comment #8 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36569&action=edit Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC On the OPAC authentification page, the acronym tag is used, but deprecated. It should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym Test plan: Enable the CAS authentification and verify the tags have correctly been replaced. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Befor the patch, "grep -r "<acronym" koha-tmpl/*/*/en/*" shows 4 occurences of <acronym>, 3 related to CAS. After the patch, the same grep shows 1 remaining <acronym>, in acqui/parcels.tt. I sign off this patch and will provide a followup for the last occurrence. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Attachment #36064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 --- Comment #9 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36572&action=edit Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP This patch replaces the last occurrence of <acronym> with <abbr>. To test: - Apply this patch on top of the first patch and check that "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36572|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36574&action=edit Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP This patch replaces the last occurrence of <acronym> with <abbr>. To test: - Apply this patch on top of the first patch and check that "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36569|0 |1 is obsolete| | Attachment #36574|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36580&action=edit [PASSED QA] Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC On the OPAC authentification page, the acronym tag is used, but deprecated. It should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym Test plan: Enable the CAS authentification and verify the tags have correctly been replaced. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Befor the patch, "grep -r "<acronym" koha-tmpl/*/*/en/*" shows 4 occurences of <acronym>, 3 related to CAS. After the patch, the same grep shows 1 remaining <acronym>, in acqui/parcels.tt. I sign off this patch and will provide a followup for the last occurrence. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36581&action=edit [PASSED QA] Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP This patch replaces the last occurrence of <acronym> with <abbr>. To test: - Apply this patch on top of the first patch and check that "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and Magnus! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org