https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |27715 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- git bisect blames Bug 27715 - Possibly SQL injection in virtualshelves Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27715 [Bug 27715] Possibly SQL injection in virtualshelves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119226&action=edit Bug 28069: (bug 27715 follow-up) Fix sort for lists Sort functionality has been broken by bug 27715. We need to specify the table.column in the datatable init Note that "count" needs to be handled separately (which is a bit dirty but cannot find something better) Test plan: Create some lists, add contents, change owner and dates Sort using the different attributes and confirm that it's now working -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't sort lists on staff |Can't sort lists on staff |cleint |client --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Is the "Owner" sort using the borrowernumber instead of borrower's name the excepted behaviour ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 --- Comment #8 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Jonathan Druart from comment #6)

Absolutely not. However it seems that it was the behaviour pre bug 27715, so it should be addressed on its own bug report.

Thank you Jonathan ! I opened bug 28105 to fix that issue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119262|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 119743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119743&action=edit Bug 28069: (bug 27715 follow-up) Fix sort for lists Sort functionality has been broken by bug 27715. We need to specify the table.column in the datatable init Note that "count" needs to be handled separately (which is a bit dirty but cannot find something better) Test plan: Create some lists, add contents, change owner and dates Sort using the different attributes and confirm that it's now working Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.