[Bug 23007] New: Make dialogs in returns.pl optionally modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Bug ID: 23007 Summary: Make dialogs in returns.pl optionally modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- Bug 21346 made some dialogs in returns.pl modal. Some libraries think this is too distruptive for their workflow and would like to continue scanning books even if there is a dialog/message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Perhaps we could use humanmsg with dismissal on keyinput/scan? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90539&action=edit Bug 23007: Make modals close on enter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Just an example, we could make the transfer modals close on enter, we could tie it to a pref if needed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Some libraries don't want staff scanning through, because they ignore the message. If you are going to make it scan through, it should be something that can be turned on or off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 caroline <cford@farmingtonlibraries.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cford@farmingtonlibraries.o | |rg --- Comment #5 from caroline <cford@farmingtonlibraries.org> --- Hi all, The change in having to say okay each time an item transfers is time consuming for my staff. We only have one branch, so we always where it is coming from or going to. We would love to see a patch soon. Thanks for all the things everyone does for the community here in bugland. Caroline Ford -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #6 from George Williams (NEKLS) <george@nekls.org> --- I agree with Christopher. We have 51 libraries and changing the transfer message to a modal is a good thing for us. Since it's not a good thing for everyone, though, I think whether this message can be scanned through or not should be a system preference. George -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90539|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91049&action=edit Bug 23007: Add TransfersBlockCirc system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91050&action=edit Bug 23007: Retain focus on 'barcode' input if transfers don't block circ To test: 1 - Apply patches 2 - Update database 3 - Confirm TransfersBlockCirc defaults to 'Block' 4 - Check in an item that needs transfer 5 - Confirm you must deal with the modal to proceed 6 - Repeat checking to get 'wrong-transfer-modal' 7 - Confirm you must deal with it to proceed 8 - Switch the pref to 'Don't block' 9 - Find a new item or cancel/fulfill the preceeding transfer 10 - Check in the item to generate transfer 11 - Note focus remains on the barcode field and you can continue scanning (or typing if you don't have a scanner) 12 - Note typing and pressing enter continues without requiring you to deal with modal 13 - Repeat for wrong transfer modal 14 - Verify hold and other modals still block continuing circulation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Jeanne Heicher <nppublib@pa.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nppublib@pa.net --- Comment #9 from Jeanne Heicher <nppublib@pa.net> --- Please make this a system preference. We choose not to interrupt workflow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- Should it be assumed that if you are not blocking, you probably are not printing, and therefore, the modal doesn't need to appear at all? Or if so, what about just putting the print slip button on the new line in the form with the title instead of having the modal? I'm just thinking that the modal covers things, and if people are not going to care about it, why show it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91049|0 |1 is obsolete| | --- Comment #11 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91506&action=edit Bug 23007: Add TransfersBlockCirc system preference Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91050|0 |1 is obsolete| | --- Comment #12 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91507&action=edit Bug 23007: Retain focus on 'barcode' input if transfers don't block circ To test: 1 - Apply patches 2 - Update database 3 - Confirm TransfersBlockCirc defaults to 'Block' 4 - Check in an item that needs transfer 5 - Confirm you must deal with the modal to proceed 6 - Repeat checking to get 'wrong-transfer-modal' 7 - Confirm you must deal with it to proceed 8 - Switch the pref to 'Don't block' 9 - Find a new item or cancel/fulfill the preceeding transfer 10 - Check in the item to generate transfer 11 - Note focus remains on the barcode field and you can continue scanning (or typing if you don't have a scanner) 12 - Note typing and pressing enter continues without requiring you to deal with modal 13 - Repeat for wrong transfer modal 14 - Verify hold and other modals still block continuing circulation Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91506|0 |1 is obsolete| | Attachment #91507|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92506&action=edit Bug 23007: Add TransfersBlockCirc system preference Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92507&action=edit Bug 23007: Retain focus on 'barcode' input if transfers don't block circ To test: 1 - Apply patches 2 - Update database 3 - Confirm TransfersBlockCirc defaults to 'Block' 4 - Check in an item that needs transfer 5 - Confirm you must deal with the modal to proceed 6 - Repeat checking to get 'wrong-transfer-modal' 7 - Confirm you must deal with it to proceed 8 - Switch the pref to 'Don't block' 9 - Find a new item or cancel/fulfill the preceeding transfer 10 - Check in the item to generate transfer 11 - Note focus remains on the barcode field and you can continue scanning (or typing if you don't have a scanner) 12 - Note typing and pressing enter continues without requiring you to deal with modal 13 - Repeat for wrong transfer modal 14 - Verify hold and other modals still block continuing circulation Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92506|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93713&action=edit Bug 23007: Add TransfersBlockCirc system preference Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92507|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93714&action=edit Bug 23007: Retain focus on 'barcode' input if transfers don't block circ To test: 1 - Apply patches 2 - Update database 3 - Confirm TransfersBlockCirc defaults to 'Block' 4 - Check in an item that needs transfer 5 - Confirm you must deal with the modal to proceed 6 - Repeat checking to get 'wrong-transfer-modal' 7 - Confirm you must deal with it to proceed 8 - Switch the pref to 'Don't block' 9 - Find a new item or cancel/fulfill the preceeding transfer 10 - Check in the item to generate transfer 11 - Note focus remains on the barcode field and you can continue scanning (or typing if you don't have a scanner) 12 - Note typing and pressing enter continues without requiring you to deal with modal 13 - Repeat for wrong transfer modal 14 - Verify hold and other modals still block continuing circulation Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 [Bug 27847] Add tip text when TransfersBlockCirc is off -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org