[Bug 4314] New: Flag for SSL Enabled to fix 3rd Party Enhanced Content in OPAC
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4314 Summary: Flag for SSL Enabled to fix 3rd Party Enhanced Content in OPAC Product: Koha Version: HEAD Platform: PC OS/Version: Windows 2000 Status: ASSIGNED Severity: enhancement Priority: P5 Component: OPAC AssignedTo: jwagner@ptfs.com ReportedBy: jwagner@ptfs.com Estimated Hours: 0.0 Change sponsored?: --- Reported by and initial code worked out by Chris Hyde, East Brunswick Public Library, East Brunswick, NJ, USA. If a library has enabled SSL encryption in the OPAC, Syndetics and LibraryThing links give error messages in Internet Explorer. The proposed fix is to add a syspref for OPAC SSL in use. Then check that syspref and pass the value to the OPAC template. If it is on, have the Syndetics and LibraryThing links use the https form of URL; otherwise, leave them at the http form of URL. Any other 3rd party content where this would be useful? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-03-10 15:44:18 --- This is also a problem with Amazon, but not sure if this solution will work there too. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4314 --- Comment #2 from Jane Wagner <jwagner@ptfs.com> 2010-03-10 16:35:45 --- We discussed on the IRC and gmcharlt had a better approach, a check in Auth.pm to see if SSL is in use. He's sent a patch for that part. I'm working on a patch for Syndetics and LibraryThing calls in the OPAC templates. I don't know what URLs might be needed for other providers like Amazon; if someone else does, similar changes could be made for those calls. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4314 --- Comment #3 from Jane Wagner <jwagner@ptfs.com> 2010-03-12 13:55:24 --- Created an attachment (id=1741) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1741) patch file Tested on a system with SSL enabled, and patch sent March 12, 2010. Note that this patch only adds the SSL check for Syndetics and LibraryThing URLs. I don't know if other enhanced content providers like Amazon or Baker & Taylor use different URLs, or if so, what those URLs are. Someone else could easily continue the work for those URLs by following the basic logic used in this patch: <!-- TMPL_IF NAME="using_https" --> (link to https version of URL) <!--TMPL_ELSE --> (link to standard http version of URL) <!-- /TMPL_IF --> The URLs appear in several template files, so you'd need to check all of them. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4314 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #4 from Jane Wagner <jwagner@ptfs.com> 2010-03-12 13:57:05 --- Note that this patch replicates the patch Galen Charlton sent on March 10 -- I couldn't get that to apply properly, and it was only a one-line change anyway so I just copied it. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4314 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> 2010-03-17 00:26:17 --- Pushed patches to HEAD. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com