[Bug 40708] New: Increase accuracy and accessibility of checkin errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Bug ID: 40708 Summary: Increase accuracy and accessibility of checkin errors Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: nick@bywatersolutions.com Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com When a checkin in Koha returns "data_corrupted," the checkin fails and koha displays the message "The item has not been checked in due to a configuration issue in your system. You must ask an administrator to take a look at the about page and correct all errors shown on the "System information."" This message should be more specific and accurate, as there are a wide variety of potential causes and not all of them are reported in any way in the About page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185911&action=edit Bug 40708: Return the specific error to the checkin page When implemented, the message here was believed to either be about Duplicate IDs, or guarantor issues. We are now seeing a wider variety of issues possible from SQL errors, lock timeout or missings rows as examples This patch adds an 'ErrorMessage' message to the return from AddReturn and displays it to the user. To test: 1 - Issue an item to a patron, note the itemnumber 2 - On the command line, lock the row: sudo koha-mysql kohadev START TRANSACTION; SELECT * FROM issues WHERE itemnumber=975 FOR UPDATE; leave mysql open at this point 3 - On the interface, check in the item, wait a bit 4 - After a bit you get the error to check the config page, but nothing is there 5 - close mysql, apply patch, restart all 6 - Repeat 2 7 - Check in the item, wait a bit 8 - Note you now get the error from the DB: Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 ) 9 - Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185911|0 |1 is obsolete| | --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185912&action=edit Bug 40708: Return the specific error to the checkin page When implemented, the message here was believed to either be about Duplicate IDs, or guarantor issues. We are now seeing a wider variety of issues possible from SQL errors, lock timeout or missings rows as examples This patch adds an 'ErrorMessage' message to the return from AddReturn and displays it to the user. To test: 1 - Issue an item to a patron, note the itemnumber 2 - On the command line, lock the row: sudo koha-mysql kohadev START TRANSACTION; SELECT * FROM issues WHERE itemnumber=975 FOR UPDATE; leave mysql open at this point 3 - On the interface, check in the item, wait a bit 4 - After a bit you get the error to check the config page, but nothing is there 5 - close mysql, apply patch, restart all 6 - Repeat 2 7 - Check in the item, wait a bit 8 - Note you now get the error from the DB: Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 ) 9 - Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185912|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 185929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185929&action=edit Bug 40708: Return the specific error to the checkin page When implemented, the message here was believed to either be about Duplicate IDs, or guarantor issues. We are now seeing a wider variety of issues possible from SQL errors, lock timeout or missings rows as examples This patch adds an 'ErrorMessage' message to the return from AddReturn and displays it to the user. To test: 1 - Issue an item to a patron, note the itemnumber 2 - On the command line, lock the row: sudo koha-mysql kohadev START TRANSACTION; SELECT * FROM issues WHERE itemnumber=975 FOR UPDATE; leave mysql open at this point 3 - On the interface, check in the item, wait a bit 4 - After a bit you get the error to check the config page, but nothing is there 5 - close mysql, apply patch, restart all 6 - Repeat 2 7 - Check in the item, wait a bit 8 - Note you now get the error from the DB: Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 ) 9 - Sign off! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- This issue has recently been affecting us. Thanks for the quick patch! Just a note on step 8, both of the error messages were displayed in this order: Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 ) The item has not been checked in due to an issue in your system. Note the error below. An administrator may find further details by looking at the about page and correcting errors shown on the "System information" tab, or note the error below. I'm signing off to move this along but the error should be displayed below the message as it says 'note the error below'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #4)
This issue has recently been affecting us. Thanks for the quick patch!
Just a note on step 8, both of the error messages were displayed in this order:
Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 )
The item has not been checked in due to an issue in your system. Note the error below. An administrator may find further details by looking at the about page and correcting errors shown on the "System information" tab, or note the error below.
I'm signing off to move this along but the error should be displayed below the message as it says 'note the error below'.
I got the error message above the explanatory text once in my testing and then could not replicate it consistently. We should end that message at "shown on the 'System information' tab." In fiddling with the wording we ended up repeating ourselves. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185929|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185943&action=edit Bug 40708: Return the specific error to the checkin page When implemented, the message here was believed to either be about Duplicate IDs, or guarantor issues. We are now seeing a wider variety of issues possible from SQL errors, lock timeout or missings rows as examples This patch adds an 'ErrorMessage' message to the return from AddReturn and displays it to the user. To test: 1 - Issue an item to a patron, note the itemnumber 2 - On the command line, lock the row: sudo koha-mysql kohadev START TRANSACTION; SELECT * FROM issues WHERE itemnumber=975 FOR UPDATE; leave mysql open at this point 3 - On the interface, check in the item, wait a bit 4 - After a bit you get the error to check the config page, but nothing is there 5 - close mysql, apply patch, restart all 6 - Repeat 2 7 - Check in the item, wait a bit 8 - Note you now get the error from the DB: Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 ) 9 - Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185943|0 |1 is obsolete| | --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 185945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185945&action=edit Bug 40708: Return the specific error to the checkin page When implemented, the message here was believed to either be about Duplicate IDs, or guarantor issues. We are now seeing a wider variety of issues possible from SQL errors, lock timeout or missings rows as examples This patch adds an 'ErrorMessage' message to the return from AddReturn and displays it to the user. To test: 1 - Issue an item to a patron, note the itemnumber 2 - On the command line, lock the row: sudo koha-mysql kohadev START TRANSACTION; SELECT * FROM issues WHERE itemnumber=975 FOR UPDATE; leave mysql open at this point 3 - On the interface, check in the item, wait a bit 4 - After a bit you get the error to check the config page, but nothing is there 5 - close mysql, apply patch, restart all 6 - Repeat 2 7 - Check in the item, wait a bit 8 - Note you now get the error from the DB: Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 ) 9 - Sign off! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- I tested with the same item I used previously and now the message and the error display in the correct order. Nice! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185945|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186468&action=edit Bug 40708: Return the specific error to the checkin page When implemented, the message here was believed to either be about Duplicate IDs, or guarantor issues. We are now seeing a wider variety of issues possible from SQL errors, lock timeout or missings rows as examples This patch adds an 'ErrorMessage' message to the return from AddReturn and displays it to the user. To test: 1 - Issue an item to a patron, note the itemnumber 2 - On the command line, lock the row: sudo koha-mysql kohadev START TRANSACTION; SELECT * FROM issues WHERE itemnumber=975 FOR UPDATE; leave mysql open at this point 3 - On the interface, check in the item, wait a bit 4 - After a bit you get the error to check the config page, but nothing is there 5 - close mysql, apply patch, restart all 6 - Repeat 2 7 - Check in the item, wait a bit 8 - Note you now get the error from the DB: Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 ) 9 - Sign off! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186469&action=edit Bug 40708: Fix link to the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186470&action=edit Bug 40708: Fix Circulation/Returns.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Notes: Getting a 500 when checking in from the checkout page Exception 'Koha::Exceptions::Checkout::FailedRenewal' thrown 'Update of issue# 3 failed with error: Lock wait timeout exceeded; try restarting transaction'
From returns.pl: """ BC_1: E Street shuffle :
The item has not been checked in due to an issue in your system. Note the error below. An administrator may find further details by looking at the about page and correcting errors shown on the "System information" tab, or note the error below. Error: (DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /kohadevbox/koha/Koha/Object.pm line 174 ) """ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to 24.11.x for UI stability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40708 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org