[Bug 21291] New: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Bug ID: 21291 Summary: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests". When clicking on article requests, you get a new sidebar without MARC Labeled MARC ISBD -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |charles.farmer@inlibro.com, | |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 78311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78311&action=edit Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests". When clicking on article requests, you get a new sidebar without MARC Labeled MARC ISBD This fix adds the required C4::Biblio::enabled_staff_search_views that loads the required hash with the permissions. TEST 0) login with a user having all rights 1) go to any detailed notices, notice the sidebar on the left 2) click on MARC 3) notice the sidebar is the same in the new page 4) click on Request articles 5) notice the missing labels on the sidebar 6) apply patch, redo steps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Patch works as described, but you missed the tab "Subscription(s)" which also disappears when we're on "Article request" + "Holds" +"Checkout history" + "Modification logs" tabs. Do you want to fix it too, or should I open a new report ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|In Discussion |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- "In Discussion" asks for more opinions, better to use "Failed QA" for questions to the developer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Oups... sorry Katrin, and thanks for the advice ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 --- Comment #5 from Blou <philippe.blouin@inlibro.com> --- Created attachment 79952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79952&action=edit Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Hold(s) Article requests Checkout history Modification log you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78311|0 |1 is obsolete| | Attachment #79952|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79958&action=edit Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Hold(s) Article requests Checkout history Modification log you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21492 [Bug 21492] Show subscriptions count in the sidebar menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, patch doesn't apply - can you have a look please? sloth:/usr/local/vagrant/kohaclone_master (30-21291-missing-navigation) $ git b apply 21291 Bug 21291 - request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar 79958 - Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar error: sha1 information is lacking or useless (circ/request-article.pl). error: could not build fake ancestor Patch failed at 0001 Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78311|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Blou <philippe.blouin@inlibro.com> --- The first patch had been obsoleted. Once put back, it all applies without problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79952|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I noticed a couple of things while working on Bug 21492 I noticed a couple of issues with this: - Missing subscriptions tab on the labeled MARC view (catalogue/labeledMARCdetail.pl) - Missing subscriptions tab on the stock rotation page (catalogue/stockrotation.pl) - The subscriptionsnumber variable being passed to the view log template is not a number as it is on other page. With Bug 21492 applied the variable is output as "Object." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79952|0 |1 is obsolete| | --- Comment #10 from Blou <philippe.blouin@inlibro.com> --- Created attachment 80369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80369&action=edit Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Labeled MARC (you need to set the syspref viewLabeledMARC) Hold(s) Article requests Checkout history Modification log Rota (you need to set the syspref StockRotation) you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78311|0 |1 is obsolete| | Attachment #80369|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80401&action=edit Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests". When clicking on article requests, you get a new sidebar without MARC Labeled MARC ISBD This fix adds the required C4::Biblio::enabled_staff_search_views that loads the required hash with the permissions. TEST 0) login with a user having all rights 1) go to any detailed notices, notice the sidebar on the left 2) click on MARC 3) notice the sidebar is the same in the new page 4) click on Request articles 5) notice the missing labels on the sidebar 6) apply patch, redo steps Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80402&action=edit Bug 21291: (follow up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Labeled MARC (you need to set the syspref viewLabeledMARC) Hold(s) Article requests Checkout history Modification log Rota (you need to set the syspref StockRotation) you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|request-article.pl doesn't |Article requests page |show MARC, LabeledMARC and |doesn't show MARC, |ISBD in sidebar |LabeledMARC and ISBD in | |sidebar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80401|0 |1 is obsolete| | Attachment #80402|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80427&action=edit Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar When on a detailed record in the intranet, any click on the sidebar will lead you to another page with the same sidebar EXCEPT for "Article requests". When clicking on article requests, you get a new sidebar without MARC Labeled MARC ISBD This fix adds the required C4::Biblio::enabled_staff_search_views that loads the required hash with the permissions. TEST 0) login with a user having all rights 1) go to any detailed notices, notice the sidebar on the left 2) click on MARC 3) notice the sidebar is the same in the new page 4) click on Request articles 5) notice the missing labels on the sidebar 6) apply patch, redo steps Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80428&action=edit Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar The subscriptionsnumber is required in biblio-view-menu.inc to display the Subscription(s) tab. In detail.pl, if you click any of Labeled MARC (you need to set the syspref viewLabeledMARC) Hold(s) Article requests Checkout history Modification log Rota (you need to set the syspref StockRotation) you lose the Subscription(s) tab. This patch fixes the display by having each feature script generate that value to be passed to the UI. I keep this separated from the first patch since it's not exactly the same issue, and the solution might not please. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- For 17.11.x I prefer not to change display of oldstable branch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org