[Bug 5059] New: Inconsistent use of ordering price and list price in vendor form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 Summary: Inconsistent use of ordering price and list price in vendor form Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All URL: /cgi-bin/koha/acqui/supplier.pl OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Templates AssignedTo: katrin.fischer@bsz-bw.de ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Created attachment 2420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2420 screenshot of new vendor form The vendor form uses the terms list price for currency and ordering price for tax information. After discussion in IRC we came to the conclusion that both terms have the same meaning. 07-26-2010 (12:16:19) chris: i think in the context of the vendor form its the same (12:16:25) chris: thats how the code uses it anyway (12:17:09) chris: it will use the currency chosen to convert the price, then if there is tax then subtract that, then remove the discount (12:18:29) chris: to end up with the estimated cost, so the currency of list price and tax of ordering price are both used for the same thing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 2421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2421 screenshot after changes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 2422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2422 proposed patch Changes Ordering price to List price and makes spelling more consistent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-11-12 20:31:05 UTC --- Rebased to HEAD without any conflicts. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-12 22:36:03 UTC --- Patch pushed test and close -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-11-14 12:19:20 UTC --- Tested with HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-18 03:15:13 UTC --- This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5059 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-11-23 10:32:10 UTC --- Successfully tested with 3.2.1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org